You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by David James <st...@gmail.com> on 2004/08/29 21:45:27 UTC
[PATCH] javaHL testBasicLogMessage test fails
In the latest version of Subversion, the "testBasicLogMessage" test
fails because the word "LogMessage" is spelled incorrectly in the test
code, but is spelled correctly in the Subversion source code. This
patch corrects the spelling in the test case, and therefore fixes this
issue.
The patch is attached.
Cheers,
David James
Type make javahl-check to get these error messages:
/usr/lib/j2se/1.4/bin/java
-Djava.library.path=/home/djames/subversion/build/install/lib
-classpath subversion/bindings/java/javahl/classes:/usr/local/lib/junit.jar
org.tigris.subversion.javahl.tests.BasicTests
....................F
Time: 130.088
There was 1 failure:
1) testBasicLogMessage(org.tigris.subversion.javahl.tests.BasicTests)
junit.framework.ComparisonFailure: wrong message expected:<......> but
was:<...s...>
at org.tigris.subversion.javahl.tests.BasicTests.testBasicLogMessage(BasicTests.java:1281)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at org.tigris.subversion.javahl.tests.BasicTests.main(BasicTests.java:67)
FAILURES!!!
Tests run: 20, Failures: 1, Errors: 0
Re: [PATCH] javaHL testBasicLogMessage test fails
Posted by David James <st...@gmail.com>.
> I do not understand, why I never hit that problem, but I will commit
> your patch later today.
Thanks Patrick.
I'm considering working on upgrading JavaHL to use SWIG instead of JNI
so that it can be more easily maintained. (E.g. so we don't have to
keep updating the JNI headers) Would such a patch be useful? If so, do
you have any recommendations as to where I should start?
My current plan is to convert the JavaHL functions one at a time to
use SWIG instead of JNI. Should I submit a separate patch for each
function (so as to make it easier to test, and so that the tree stays
in sync with my changes)?
Cheers,
David
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] javaHL testBasicLogMessage test fails
Posted by Patrick Mayweg <ma...@qint.de>.
Hi David,
I do not understand, why I never hit that problem, but I will commit
your patch later today.
Regards,
Patrick
David James wrote:
>In the latest version of Subversion, the "testBasicLogMessage" test
>fails because the word "LogMessage" is spelled incorrectly in the test
>code, but is spelled correctly in the Subversion source code. This
>patch corrects the spelling in the test case, and therefore fixes this
>issue.
>
>The patch is attached.
>
>Cheers,
>
>David James
>
>Type make javahl-check to get these error messages:
>/usr/lib/j2se/1.4/bin/java
>-Djava.library.path=/home/djames/subversion/build/install/lib
>-classpath subversion/bindings/java/javahl/classes:/usr/local/lib/junit.jar
>org.tigris.subversion.javahl.tests.BasicTests
>....................F
>Time: 130.088
>There was 1 failure:
>1) testBasicLogMessage(org.tigris.subversion.javahl.tests.BasicTests)
>junit.framework.ComparisonFailure: wrong message expected:<......> but
>was:<...s...>
> at org.tigris.subversion.javahl.tests.BasicTests.testBasicLogMessage(BasicTests.java:1281)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at org.tigris.subversion.javahl.tests.BasicTests.main(BasicTests.java:67)
>
>FAILURES!!!
>Tests run: 20, Failures: 1, Errors: 0
>
>
>------------------------------------------------------------------------
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
>For additional commands, e-mail: dev-help@subversion.tigris.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] javaHL testBasicLogMessage test fails
Posted by Patrick Mayweg <ma...@qint.de>.
Hi David,
thanks for the patch. I have commited it in r10773.
Thanks,
Patrick
David James wrote:
>In the latest version of Subversion, the "testBasicLogMessage" test
>fails because the word "LogMessage" is spelled incorrectly in the test
>code, but is spelled correctly in the Subversion source code. This
>patch corrects the spelling in the test case, and therefore fixes this
>issue.
>
>The patch is attached.
>
>Cheers,
>
>David James
>
>Type make javahl-check to get these error messages:
>/usr/lib/j2se/1.4/bin/java
>-Djava.library.path=/home/djames/subversion/build/install/lib
>-classpath subversion/bindings/java/javahl/classes:/usr/local/lib/junit.jar
>org.tigris.subversion.javahl.tests.BasicTests
>....................F
>Time: 130.088
>There was 1 failure:
>1) testBasicLogMessage(org.tigris.subversion.javahl.tests.BasicTests)
>junit.framework.ComparisonFailure: wrong message expected:<......> but
>was:<...s...>
> at org.tigris.subversion.javahl.tests.BasicTests.testBasicLogMessage(BasicTests.java:1281)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at org.tigris.subversion.javahl.tests.BasicTests.main(BasicTests.java:67)
>
>FAILURES!!!
>Tests run: 20, Failures: 1, Errors: 0
>
>
>------------------------------------------------------------------------
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
>For additional commands, e-mail: dev-help@subversion.tigris.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org