You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Carlos Sanchez (JIRA)" <ji...@codehaus.org> on 2007/04/28 01:29:26 UTC

[jira] Created: (MNG-2968) Forbid dots in artifactId

Forbid dots in artifactId
-------------------------

                 Key: MNG-2968
                 URL: http://jira.codehaus.org/browse/MNG-2968
             Project: Maven 2
          Issue Type: Improvement
          Components: POM
    Affects Versions: 2.0.6, 2.1-alpha-1
            Reporter: Carlos Sanchez
             Fix For: 2.1-alpha-1


artifactIds with dots are potential trouble. They prevent using groupId.artifactId as identifier and later parse it back

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-2968) Forbid dots in artifactId

Posted by "Jacob Robertson (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_94824 ] 

Jacob Robertson commented on MNG-2968:
--------------------------------------

Let me give an example of where you might like to have dots which follow the expected java package structure inside a project.

project name:webservices.util
cvs module name:webservices.util
groupId:com.mycompany.webservices
artifactId:webservices.util

project name:webservices.xfire
cvs module name:webservices.xfire
groupId:com.mycompany.webservices
artifactId:webservices.xfire

We wouldn't want to have an artifact id of just "util" for the first project, because that would be confusing and problematic with tools like copy-dependencies since we'd undoubtably have more than one project with an artifact of "util".  So, we'd be more likely to do "webservices-util" which now means our artifact id is out of synch with (A) the project name, (B) the cvs module name and (C) the java package name.

> Forbid dots in artifactId
> -------------------------
>
>                 Key: MNG-2968
>                 URL: http://jira.codehaus.org/browse/MNG-2968
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: POM
>    Affects Versions: 2.0.6, 2.1-alpha-1
>            Reporter: Carlos Sanchez
>             Fix For: 2.1-alpha-1
>
>
> artifactIds with dots are potential trouble. They prevent using groupId.artifactId as identifier and later parse it back

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-2968) Forbid dots in artifactId

Posted by "Jacob Robertson (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_94830 ] 

Jacob Robertson commented on MNG-2968:
--------------------------------------

I certainly understand and respect what you're trying to accomplish, but the sad fact is that if this suggested fix is implemented, it will break 90% of the artifacts in my company, and will mean we have to do re-tooling on the inhouse things we've done that depend on artifact id, cvs module name, and project name all being the same.  This is a sweeping, non-backwards-compatible change, and it shouldn't be done lightly.

> Forbid dots in artifactId
> -------------------------
>
>                 Key: MNG-2968
>                 URL: http://jira.codehaus.org/browse/MNG-2968
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: POM
>    Affects Versions: 2.0.6, 2.1-alpha-1
>            Reporter: Carlos Sanchez
>             Fix For: 2.1-alpha-1
>
>
> artifactIds with dots are potential trouble. They prevent using groupId.artifactId as identifier and later parse it back

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-2968) Forbid dots in artifactId

Posted by "Carlos Sanchez (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_94826 ] 

Carlos Sanchez commented on MNG-2968:
-------------------------------------

I understand, and this change won't happen before the tools like the copy-dependencies support this other way

this is how I see it

project name:util
groupId:com.mycompany.webservices
artifactId:util

war, copy-dependencies, eclipse,... would use as id/name of the jar/... com.mycompany.webservices.util

because still, webservices.util may conflict with something else

> Forbid dots in artifactId
> -------------------------
>
>                 Key: MNG-2968
>                 URL: http://jira.codehaus.org/browse/MNG-2968
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: POM
>    Affects Versions: 2.0.6, 2.1-alpha-1
>            Reporter: Carlos Sanchez
>             Fix For: 2.1-alpha-1
>
>
> artifactIds with dots are potential trouble. They prevent using groupId.artifactId as identifier and later parse it back

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-2968) Forbid dots in artifactId

Posted by "Jacob Robertson (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_94788 ] 

Jacob Robertson commented on MNG-2968:
--------------------------------------

Making this change would be costly for my company, as our standard is to use dots in all our artifact names instead of dashes.  Our group ids and artifact ids are designed to closely mimic the top-level package names in each java project.  This allows us to use consistent naming standards in eclipse, maven, cvs, and java packages.  All with dots.

To make this change, I think you'll first have to quantify very clearly what the actual benefits are versus the risk of making another sweeping backwards incompatible change.

> Forbid dots in artifactId
> -------------------------
>
>                 Key: MNG-2968
>                 URL: http://jira.codehaus.org/browse/MNG-2968
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: POM
>    Affects Versions: 2.0.6, 2.1-alpha-1
>            Reporter: Carlos Sanchez
>             Fix For: 2.1-alpha-1
>
>
> artifactIds with dots are potential trouble. They prevent using groupId.artifactId as identifier and later parse it back

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-2968) Forbid dots in artifactId

Posted by "Carlos Sanchez (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_94822 ] 

Carlos Sanchez commented on MNG-2968:
-------------------------------------

to mimic the package names is why there's groupId+artifactId
groupId can have dots, artifactId shouldn't

but to do this the other plugins should use the concatenation of groupId+artifactId, like the eclipse plugin.

> Forbid dots in artifactId
> -------------------------
>
>                 Key: MNG-2968
>                 URL: http://jira.codehaus.org/browse/MNG-2968
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: POM
>    Affects Versions: 2.0.6, 2.1-alpha-1
>            Reporter: Carlos Sanchez
>             Fix For: 2.1-alpha-1
>
>
> artifactIds with dots are potential trouble. They prevent using groupId.artifactId as identifier and later parse it back

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-2968) Forbid dots in artifactId

Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_106235 ] 

Jason van Zyl commented on MNG-2968:
------------------------------------

I don't think we can do this. You are going to tank tons and tons of builds. We allowed this so it's like the envars where we didn't do this up front so now we have to live with. Something like this so fundamental can't change. We just have to suck it up.

> Forbid dots in artifactId
> -------------------------
>
>                 Key: MNG-2968
>                 URL: http://jira.codehaus.org/browse/MNG-2968
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: POM
>    Affects Versions: 2.0.6, 2.1-alpha-1
>            Reporter: Carlos Sanchez
>             Fix For: 2.1-alpha-1
>
>
> artifactIds with dots are potential trouble. They prevent using groupId.artifactId as identifier and later parse it back

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-2968) Forbid dots in artifactId

Posted by "Joerg Schaible (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_94832 ] 

Joerg Schaible commented on MNG-2968:
-------------------------------------

Isn't it possible to use a colon as separator? This is also used in several notations already e.g. when defining the included artifacts in the depednencySet of the assembly descriptor.

> Forbid dots in artifactId
> -------------------------
>
>                 Key: MNG-2968
>                 URL: http://jira.codehaus.org/browse/MNG-2968
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: POM
>    Affects Versions: 2.0.6, 2.1-alpha-1
>            Reporter: Carlos Sanchez
>             Fix For: 2.1-alpha-1
>
>
> artifactIds with dots are potential trouble. They prevent using groupId.artifactId as identifier and later parse it back

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MNG-2968) Forbid dots in artifactId

Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason van Zyl closed MNG-2968.
------------------------------

    Resolution: Won't Fix

We simply can't do this for backward compatibility reasons. It's just too much pain for users.

> Forbid dots in artifactId
> -------------------------
>
>                 Key: MNG-2968
>                 URL: http://jira.codehaus.org/browse/MNG-2968
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: POM
>    Affects Versions: 2.0.6, 2.1-alpha-1
>            Reporter: Carlos Sanchez
>             Fix For: 2.1-alpha-1
>
>
> artifactIds with dots are potential trouble. They prevent using groupId.artifactId as identifier and later parse it back

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-2968) Forbid dots in artifactId

Posted by "Carlos Sanchez (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carlos Sanchez updated MNG-2968:
--------------------------------

    Fix Version/s: 2.1-alpha-1

For instance
org.mortbay.jetty:servlet-api-2.5

> Forbid dots in artifactId
> -------------------------
>
>                 Key: MNG-2968
>                 URL: http://jira.codehaus.org/browse/MNG-2968
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: POM
>    Affects Versions: 2.0.6, 2.1-alpha-1
>            Reporter: Carlos Sanchez
>             Fix For: 2.1-alpha-1
>
>
> artifactIds with dots are potential trouble. They prevent using groupId.artifactId as identifier and later parse it back

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira