You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/17 09:39:47 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #9975: ARROW-12325: [C++] [CI] Nightly gandiva build failing due to failure of compiler to move return value

pitrou commented on a change in pull request #9975:
URL: https://github.com/apache/arrow/pull/9975#discussion_r615233852



##########
File path: cpp/src/arrow/util/vector.h
##########
@@ -130,7 +130,7 @@ Result<std::vector<T>> UnwrapOrRaise(std::vector<Result<T>>&& results) {
     }
     out.push_back(it->MoveValueUnsafe());
   }
-  return out;
+  return std::move(out);

Review comment:
       Agreed with @cyb70289 . RVO is only guaranteed if the returned value has the exact return type declared by the function.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org