[GitHub] [airflow] uranusjr commented on a diff in pull request #28771: Fix #26796 .. await_container_completion has a negated condition

[GitBox <gi...@apache.org>]

uranusjr commented on code in PR #28771:
URL: https://github.com/apache/airflow/pull/28771#discussion_r1063680510


##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -265,7 +265,14 @@ def consume_logs(*, since_time: DateTime | None = None, follow: bool = True) ->
                 time.sleep(1)
 
     def await_container_completion(self, pod: V1Pod, container_name: str) -> None:
-        while not self.container_is_running(pod=pod, container_name=container_name):
+        """
+        Waits for the given container in the given pod to be completed
+
+        :param pod: pod spec that will be monitored
+        :param container_name: name of the container within the pod to monitor
+        :return:

Review Comment:
   ```suggestion
   ```
   
   No need (or use) for an empty return annotation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org