You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by agresch <gi...@git.apache.org> on 2018/04/06 15:39:38 UTC
[GitHub] storm pull request #2624: STORM-2909 port new metrics to 2.x branch
GitHub user agresch opened a pull request:
https://github.com/apache/storm/pull/2624
STORM-2909 port new metrics to 2.x branch
@ptgoetz
Ported the new metrics code from 1.2 to 2.x. Verified ConsoleReporter spit out some of the new metrics.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/agresch/storm agresch_newmetrics_port
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2624.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2624
----
commit f35c5c76c41238e6f5c3b830910d51fb33813cdb
Author: Aaron Gresch <ag...@...>
Date: 2018-04-05T19:42:03Z
STORM-2909 port new metrics to 2.x branch
----
---
[GitHub] storm pull request #2624: STORM-2909 port new metrics to 2.x branch
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2624
---
[GitHub] storm pull request #2624: STORM-2909 port new metrics to 2.x branch
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2624#discussion_r180049067
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java ---
@@ -223,7 +224,7 @@ private Object loadWorker(Map<String, Object> topologyConf, IStateStorage stateS
// This thread will send out messages destined for remote tasks (on other workers)
- if ( ( (Long)topologyConf.get(Config.TOPOLOGY_WORKERS) ) > 1 ) {
+ if (((Long)topologyConf.get(Config.TOPOLOGY_WORKERS)) > 1) {
--- End diff --
Please rebase with latest master.
---
[GitHub] storm issue #2624: STORM-2909 port new metrics to 2.x branch
Posted by agresch <gi...@git.apache.org>.
Github user agresch commented on the issue:
https://github.com/apache/storm/pull/2624
@HeartSaVioR made the changes you suggested. I can look at the documentation changes.
---
[GitHub] storm pull request #2624: STORM-2909 port new metrics to 2.x branch
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2624#discussion_r180053408
--- Diff: storm-server/src/main/java/org/apache/storm/nimbus/DefaultTopologyValidator.java ---
@@ -15,19 +15,53 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+
package org.apache.storm.nimbus;
+import java.util.Map;
+import org.apache.storm.generated.Bolt;
import org.apache.storm.generated.InvalidTopologyException;
+import org.apache.storm.generated.SpoutSpec;
import org.apache.storm.generated.StormTopology;
-import java.util.Map;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
public class DefaultTopologyValidator implements ITopologyValidator {
+ private static final Logger LOG = LoggerFactory.getLogger(DefaultTopologyValidator.class);
@Override
- public void prepare(Map<String, Object> StormConf){
+ public void prepare(Map stormConf){
--- End diff --
Please keep exposing generic type if possible.
---
[GitHub] storm issue #2624: STORM-2909 port new metrics to 2.x branch
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2624
Could you take up copying documentation from another PR as well, based on #2526?
---