You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/02/19 12:17:31 UTC
[GitHub] [incubator-inlong] herywang opened a new pull request #2602: [INLONG-2600][Manager] Rename some database table and its entity clas…
herywang opened a new pull request #2602:
URL: https://github.com/apache/incubator-inlong/pull/2602
Fixes #2600
### Motivation
Rename some class file and database name.
### Modifications
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] herywang removed a comment on pull request #2602: [INLONG-2600][Manager] Rename the third party cluster class name and table name
Posted by GitBox <gi...@apache.org>.
herywang removed a comment on pull request #2602:
URL: https://github.com/apache/incubator-inlong/pull/2602#issuecomment-1046026572
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] herywang commented on a change in pull request #2602: [INLONG-2600][Manager] Rename the third party cluster class name and table name
Posted by GitBox <gi...@apache.org>.
herywang commented on a change in pull request #2602:
URL: https://github.com/apache/incubator-inlong/pull/2602#discussion_r810576995
##########
File path: inlong-manager/manager-dao/src/main/resources/generatorConfig.xml
##########
@@ -114,7 +114,7 @@
enableCountByExample="false" enableDeleteByExample="false"
enableSelectByExample="false" enableUpdateByExample="false"/>
- <table tableName="cluster_info" domainObjectName="ClusterInfoEntity"
+ <table tableName="third_party_cluster" domainObjectName="ClusterInfoEntity"
Review comment:
I got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] herywang closed pull request #2602: [INLONG-2600][Manager] Rename the third party cluster class name and table name
Posted by GitBox <gi...@apache.org>.
herywang closed pull request #2602:
URL: https://github.com/apache/incubator-inlong/pull/2602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a change in pull request #2602: [INLONG-2600][Manager] Rename the third party cluster class name and table name
Posted by GitBox <gi...@apache.org>.
healchow commented on a change in pull request #2602:
URL: https://github.com/apache/incubator-inlong/pull/2602#discussion_r810576451
##########
File path: inlong-manager/manager-dao/src/main/resources/generatorConfig.xml
##########
@@ -114,7 +114,7 @@
enableCountByExample="false" enableDeleteByExample="false"
enableSelectByExample="false" enableUpdateByExample="false"/>
- <table tableName="cluster_info" domainObjectName="ClusterInfoEntity"
+ <table tableName="third_party_cluster" domainObjectName="ClusterInfoEntity"
Review comment:
The `domainObjectName` should change at the same time.
##########
File path: inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/ThirdPartyClusterInfoEntity.java
##########
@@ -23,7 +23,7 @@
import java.util.Date;
@Data
-public class ClusterInfoEntity implements Serializable {
+public class ThirdPartyClusterInfoEntity implements Serializable {
Review comment:
Please change it to `ThirdPartyClusterEntity`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] herywang commented on pull request #2602: [INLONG-2600][Manager] Rename the third party cluster class name and table name
Posted by GitBox <gi...@apache.org>.
herywang commented on pull request #2602:
URL: https://github.com/apache/incubator-inlong/pull/2602#issuecomment-1046026572
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a change in pull request #2602: [INLONG-2600][Manager] Rename the third party cluster class name and table name
Posted by GitBox <gi...@apache.org>.
healchow commented on a change in pull request #2602:
URL: https://github.com/apache/incubator-inlong/pull/2602#discussion_r810581078
##########
File path: inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/mapper/ThirdPartyClusterMapper.java
##########
@@ -19,28 +19,28 @@
import org.apache.ibatis.annotations.Param;
import org.apache.inlong.manager.common.pojo.cluster.ClusterRequest;
-import org.apache.inlong.manager.dao.entity.ClusterInfoEntity;
+import org.apache.inlong.manager.dao.entity.ThirdPartyClusterEntity;
import org.springframework.stereotype.Repository;
import java.util.List;
@Repository
-public interface ClusterInfoMapper {
+public interface ThirdPartyClusterMapper {
Review comment:
Please change it to `ThirdPartyClusterEntityMapper`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on pull request #2602: [INLONG-2600][Manager] Rename some database table and its entity clas…
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #2602:
URL: https://github.com/apache/incubator-inlong/pull/2602#issuecomment-1046023992
the commit message is not specific, please highlight the changed objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #2602: [INLONG-2600][Manager] Rename the third party cluster class name and table name
Posted by GitBox <gi...@apache.org>.
healchow merged pull request #2602:
URL: https://github.com/apache/incubator-inlong/pull/2602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org