[GitHub] [cordova-plugin-inappbrowser] NiklasMerz opened a new pull request #534: Fix inappbrowser not opening on iOS 13 by using reusable window

[GitBox <gi...@apache.org>]

NiklasMerz opened a new pull request #534: Fix inappbrowser not opening on iOS 13 by using reusable window
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/534
 
 
   Closes #492
   
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   Solution for Issue #492 . InAppBrowser closed instantly after opening when using WKWebView and iOS 13 beta.
   
   
   ### Description
   <!-- Describe your changes in detail -->
   Like @jcesarmobile suggested the show method for WKWebView now is similar to UIWebView. The `hidden` option is checked like UIWebView, too.
   
   Please review if this change is makes sense or the other show method was done like that for some reason.
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Run sample app with hidden yes and no.
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org