[jira] [Commented] (LUCENE-3577) rename expungeDeletes

["Robert Muir (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-3577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150418#comment-13150418 ] 

Robert Muir commented on LUCENE-3577:
-------------------------------------

Also I think this method could do with some javadocs cleanup:
from the javadocs it is practically begging you to call it if you
ever delete, but doesn't TieredMP already handle this well?
                
> rename expungeDeletes
> ---------------------
>
>                 Key: LUCENE-3577
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3577
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Robert Muir
>
> Similar to optimize(), expungeDeletes() has a misleading name.
> We already had problems with this on the user list because TieredMergePolicy
> didn't 'expunge' all their deletes.
> Also I think expunge is the wrong word, because expunge makes it seem
> like you just wrangle up the deletes and kick them out of the party and
> that it should be fast.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org