You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/21 18:11:23 UTC

[GitHub] [airflow] Lord-Y opened a new pull request #13816: [kubernetes_generate_dag_yaml] - Fix dag yaml generate func in version 1.10.14

Lord-Y opened a new pull request #13816:
URL: https://github.com/apache/airflow/pull/13816


   Signed-off-by: Lord-Y <Lo...@users.noreply.github.com>
   
   When trying to debug the generated yaml pod to see why I'm not having the right docker image I got this error:
   
   ```
   airflow kubernetes generate-dag-yaml DAG_NAME 2021-01-19T20:00:00+00:00
   
   [2021-01-21 09:52:56,314] {{__init__.py:50}} INFO - Using executor KubernetesExecutor
   [2021-01-21 09:52:56,317] {{dagbag.py:417}} INFO - Filling up the DagBag from /opt/airflow/dags/airflow-dags.git
   Traceback (most recent call last):
     File "/home/airflow/.local/bin/airflow", line 37, in <module>
       args.func(args)
     File "/home/airflow/.local/lib/python3.8/site-packages/airflow/utils/cli.py", line 233, in wrapper
       func(args)
     File "/home/airflow/.local/lib/python3.8/site-packages/airflow/utils/cli.py", line 81, in wrapper
       return f(*args, **kwargs)
     File "/home/airflow/.local/lib/python3.8/site-packages/airflow/bin/cli.py", line 1367, in kubernetes_generate_dag_yaml
       pod = PodGenerator.construct_pod(
   TypeError: construct_pod() got an unexpected keyword argument 'kube_executor_config'
   ```
   After fixing `kube_executor_config`, I got the same error for `worker_config` parameter and also `kube_image` was missing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13816: [kubernetes_generate_dag_yaml] - Fix dag yaml generate func in version 1.10.14

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #13816:
URL: https://github.com/apache/airflow/pull/13816#issuecomment-764838873

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13816: [kubernetes_generate_dag_yaml] - Fix dag yaml generate func in version 1.10.14

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #13816:
URL: https://github.com/apache/airflow/pull/13816#issuecomment-773540822


   Awesome work, congrats on your first merged pull request!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] Lord-Y commented on pull request #13816: [kubernetes_generate_dag_yaml] - Fix dag yaml generate func in version 1.10.14

Posted by GitBox <gi...@apache.org>.

Lord-Y commented on pull request #13816:
URL: https://github.com/apache/airflow/pull/13816#issuecomment-769800124


   @kaxil Can you get some time to have a look on SQL part :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #13816: [kubernetes_generate_dag_yaml] - Fix dag yaml generate func in version 1.10.14

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #13816:
URL: https://github.com/apache/airflow/pull/13816#issuecomment-769985196


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13816: [kubernetes_generate_dag_yaml] - Fix dag yaml generate func in version 1.10.14

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #13816:
URL: https://github.com/apache/airflow/pull/13816#issuecomment-773540822


   Awesome work, congrats on your first merged pull request!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] dimberman merged pull request #13816: [kubernetes_generate_dag_yaml] - Fix dag yaml generate func in version 1.10.14

Posted by GitBox <gi...@apache.org>.

dimberman merged pull request #13816:
URL: https://github.com/apache/airflow/pull/13816


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] dimberman merged pull request #13816: [kubernetes_generate_dag_yaml] - Fix dag yaml generate func in version 1.10.14

Posted by GitBox <gi...@apache.org>.

dimberman merged pull request #13816:
URL: https://github.com/apache/airflow/pull/13816


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13816: [kubernetes_generate_dag_yaml] - Fix dag yaml generate func in version 1.10.14

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #13816:
URL: https://github.com/apache/airflow/pull/13816#issuecomment-764838873

For queries about this service, please contact Infrastructure at:
users@infra.apache.org