[GitHub] [druid] kfaraz commented on a change in pull request #12021: Fix bad lookup config fails task

[GitBox <gi...@apache.org>]

kfaraz commented on a change in pull request #12021:
URL: https://github.com/apache/druid/pull/12021#discussion_r762378594



##########
File path: server/src/main/java/org/apache/druid/query/lookup/LookupUtils.java
##########
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.query.lookup;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.google.common.collect.Maps;
+import org.apache.druid.java.util.emitter.EmittingLogger;
+
+import java.io.IOException;
+import java.util.Map;
+
+/**
+ * Utility class for lookup related things
+ */
+public class LookupUtils
+{
+
+  private static final EmittingLogger LOG = new EmittingLogger(LookupUtils.class);
+
+  private LookupUtils()
+  {
+
+  }
+
+  /**
+   * Takes a map of String to Object, representing lookup name to generic lookup config, and attempts to construct
+   * a map from String to {@link LookupExtractorFactoryContainer}. Any lookup configs that are not able to be converted
+   * to {@link LookupExtractorFactoryContainer}, will be logged as warning, and will not be included in the map
+   * returned.
+   *
+   * @param lookupNameToGenericConfig The lookup generic config map.
+   * @param objectMapper The object mapper to use to convert bytes to {@link LookupExtractorFactoryContainer}
+   * @return
+   */
+  public static Map<String, LookupExtractorFactoryContainer> convertObjectMapToLookupExtractorFactoryContainerMapAndSkipErrors(

Review comment:
       Nit: Could this method be renamed to something like `tryConvertObjectMapToLookupConfigMap` to make it less verbose?

##########
File path: server/src/main/java/org/apache/druid/query/lookup/LookupUtils.java
##########
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.query.lookup;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.google.common.collect.Maps;
+import org.apache.druid.java.util.emitter.EmittingLogger;
+
+import java.io.IOException;
+import java.util.Map;
+
+/**
+ * Utility class for lookup related things
+ */
+public class LookupUtils

Review comment:
       *Nit: style choice*
   
   Instead of doing this in a new utils class, would it make sense to add this logic in `LookupReferencesManager` itself?
   We could just pass the `LookupState<Object>` to the manager and let it do the rest.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org