You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhiwei Chen <zh...@gmail.com> on 2016/03/04 03:31:24 UTC

Review Request 44376: Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44376/
-----------------------------------------------------------

Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, and Neil Conway.


Bugs: MESOS-4612
    https://issues.apache.org/jira/browse/MESOS-4612


Repository: mesos


Description
-------

Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.


Diffs
-----

  3rdparty/Makefile.am 3782583b7683d9d3bb61e7e8a1953bc3f61055f0 
  3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 
  3rdparty/versions.am 3f4513d960901bc0c014cc7ca148bf5bd43f5995 
  3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da 
  3rdparty/zookeeper-3.4.5.tar.gz 1a547fe17a6fad86012f855d3c4cc38fed4899fc 
  3rdparty/zookeeper-3.4.8.patch PRE-CREATION 
  src/examples/java/test-log.in 4c8547aaa115779ae7cec58edde01ab85feeb1b1 
  src/python/native/ext_modules.py.in 4682e5eed0f7be23fb48ef628e1bebc7741431d7 
  src/tests/zookeeper_test_server.cpp 0dc041fef8973d35114b9f76a6a4002853884670 

Diff: https://reviews.apache.org/r/44376/diff/


Testing
-------


Thanks,

Zhiwei Chen


Re: Review Request 44376: Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44376/#review122381
-----------------------------------------------------------



Bad patch!

Reviews applied: [44376]

Failed command: ./support/apply-review.sh -n -r 44376

Error:
2016-03-07 21:33:02 URL:https://reviews.apache.org/r/44376/diff/raw/ [9353/9353] -> "44376.patch" [1]
error: missing binary patch data for '3rdparty/zookeeper-3.4.8.tar.gz'
error: binary patch does not apply to '3rdparty/zookeeper-3.4.5.tar.gz'
error: 3rdparty/zookeeper-3.4.5.tar.gz: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/11883/console

- Mesos ReviewBot


On March 4, 2016, 9:22 a.m., Zhiwei Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44376/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 9:22 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, and Neil Conway.
> 
> 
> Bugs: MESOS-4612
>     https://issues.apache.org/jira/browse/MESOS-4612
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am 49aa55741d76aa88c8fbb526f18908312bb0c717 
>   3rdparty/cmake/Versions.cmake 6eac4dc0f7189e209e7d7232419e4de4bc0875c0 
>   3rdparty/versions.am c2dae2fb521b12344b93bf771dd5497ba8d446c3 
>   3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da 
>   3rdparty/zookeeper-3.4.5.tar.gz 1a547fe17a6fad86012f855d3c4cc38fed4899fc 
>   3rdparty/zookeeper-3.4.8.patch PRE-CREATION 
>   src/examples/java/test-log.in 4c8547aaa115779ae7cec58edde01ab85feeb1b1 
>   src/python/native/ext_modules.py.in eb93864733713dddad66141c6b8b6cd895f41484 
>   src/tests/zookeeper_test_server.cpp 0dc041fef8973d35114b9f76a6a4002853884670 
> 
> Diff: https://reviews.apache.org/r/44376/diff/
> 
> 
> Testing
> -------
> 
> Added a new patch that solved [ZOOKEEPER-1643](https://issues.apache.org/jira/browse/ZOOKEEPER-1643)
> 
> The original patch: <https://github.com/apache/zookeeper/commit/46b565e6abd8423c43f1bb8da782d76bac7c392c>
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>


Re: Review Request 44376: Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.

Posted by Zhiwei Chen <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44376/
-----------------------------------------------------------

(Updated March 4, 2016, 5:22 p.m.)


Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, and Neil Conway.


Bugs: MESOS-4612
    https://issues.apache.org/jira/browse/MESOS-4612


Repository: mesos


Description
-------

Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.


Diffs (updated)
-----

  3rdparty/Makefile.am 49aa55741d76aa88c8fbb526f18908312bb0c717 
  3rdparty/cmake/Versions.cmake 6eac4dc0f7189e209e7d7232419e4de4bc0875c0 
  3rdparty/versions.am c2dae2fb521b12344b93bf771dd5497ba8d446c3 
  3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da 
  3rdparty/zookeeper-3.4.5.tar.gz 1a547fe17a6fad86012f855d3c4cc38fed4899fc 
  3rdparty/zookeeper-3.4.8.patch PRE-CREATION 
  src/examples/java/test-log.in 4c8547aaa115779ae7cec58edde01ab85feeb1b1 
  src/python/native/ext_modules.py.in eb93864733713dddad66141c6b8b6cd895f41484 
  src/tests/zookeeper_test_server.cpp 0dc041fef8973d35114b9f76a6a4002853884670 

Diff: https://reviews.apache.org/r/44376/diff/


Testing
-------

Added a new patch that solved [ZOOKEEPER-1643](https://issues.apache.org/jira/browse/ZOOKEEPER-1643)

The original patch: <https://github.com/apache/zookeeper/commit/46b565e6abd8423c43f1bb8da782d76bac7c392c>


Thanks,

Zhiwei Chen


Re: Review Request 44376: Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.

Posted by haosdent huang <ha...@gmail.com>.

> On March 4, 2016, 2:55 a.m., haosdent huang wrote:
> > Ship It!

Sorry, I found you binary file in this patch is incomplete when you submit it. Could you apply this https://reviews.reviewboard.org/r/7571/diff/1#index_header to you rbtools and upload the patch again?


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44376/#review121999
-----------------------------------------------------------


On March 4, 2016, 9:22 a.m., Zhiwei Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44376/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 9:22 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, and Neil Conway.
> 
> 
> Bugs: MESOS-4612
>     https://issues.apache.org/jira/browse/MESOS-4612
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am 49aa55741d76aa88c8fbb526f18908312bb0c717 
>   3rdparty/cmake/Versions.cmake 6eac4dc0f7189e209e7d7232419e4de4bc0875c0 
>   3rdparty/versions.am c2dae2fb521b12344b93bf771dd5497ba8d446c3 
>   3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da 
>   3rdparty/zookeeper-3.4.5.tar.gz 1a547fe17a6fad86012f855d3c4cc38fed4899fc 
>   3rdparty/zookeeper-3.4.8.patch PRE-CREATION 
>   src/examples/java/test-log.in 4c8547aaa115779ae7cec58edde01ab85feeb1b1 
>   src/python/native/ext_modules.py.in eb93864733713dddad66141c6b8b6cd895f41484 
>   src/tests/zookeeper_test_server.cpp 0dc041fef8973d35114b9f76a6a4002853884670 
> 
> Diff: https://reviews.apache.org/r/44376/diff/
> 
> 
> Testing
> -------
> 
> Added a new patch that solved [ZOOKEEPER-1643](https://issues.apache.org/jira/browse/ZOOKEEPER-1643)
> 
> The original patch: <https://github.com/apache/zookeeper/commit/46b565e6abd8423c43f1bb8da782d76bac7c392c>
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>


Re: Review Request 44376: Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44376/#review121999
-----------------------------------------------------------


Ship it!




Ship It!

- haosdent huang


On March 4, 2016, 2:33 a.m., Zhiwei Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44376/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 2:33 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, and Neil Conway.
> 
> 
> Bugs: MESOS-4612
>     https://issues.apache.org/jira/browse/MESOS-4612
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am 3782583b7683d9d3bb61e7e8a1953bc3f61055f0 
>   3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 
>   3rdparty/versions.am 3f4513d960901bc0c014cc7ca148bf5bd43f5995 
>   3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da 
>   3rdparty/zookeeper-3.4.5.tar.gz 1a547fe17a6fad86012f855d3c4cc38fed4899fc 
>   3rdparty/zookeeper-3.4.8.patch PRE-CREATION 
>   src/examples/java/test-log.in 4c8547aaa115779ae7cec58edde01ab85feeb1b1 
>   src/python/native/ext_modules.py.in 4682e5eed0f7be23fb48ef628e1bebc7741431d7 
>   src/tests/zookeeper_test_server.cpp 0dc041fef8973d35114b9f76a6a4002853884670 
> 
> Diff: https://reviews.apache.org/r/44376/diff/
> 
> 
> Testing
> -------
> 
> Added a new patch that solved [ZOOKEEPER-1643](https://issues.apache.org/jira/browse/ZOOKEEPER-1643)
> 
> The original patch: <https://github.com/apache/zookeeper/commit/46b565e6abd8423c43f1bb8da782d76bac7c392c>
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>


Re: Review Request 44376: Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.

Posted by Zhiwei Chen <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44376/
-----------------------------------------------------------

(Updated March 4, 2016, 10:33 a.m.)


Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, and Neil Conway.


Bugs: MESOS-4612
    https://issues.apache.org/jira/browse/MESOS-4612


Repository: mesos


Description
-------

Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.


Diffs
-----

  3rdparty/Makefile.am 3782583b7683d9d3bb61e7e8a1953bc3f61055f0 
  3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 
  3rdparty/versions.am 3f4513d960901bc0c014cc7ca148bf5bd43f5995 
  3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da 
  3rdparty/zookeeper-3.4.5.tar.gz 1a547fe17a6fad86012f855d3c4cc38fed4899fc 
  3rdparty/zookeeper-3.4.8.patch PRE-CREATION 
  src/examples/java/test-log.in 4c8547aaa115779ae7cec58edde01ab85feeb1b1 
  src/python/native/ext_modules.py.in 4682e5eed0f7be23fb48ef628e1bebc7741431d7 
  src/tests/zookeeper_test_server.cpp 0dc041fef8973d35114b9f76a6a4002853884670 

Diff: https://reviews.apache.org/r/44376/diff/


Testing (updated)
-------

Added a new patch that solved [ZOOKEEPER-1643](https://issues.apache.org/jira/browse/ZOOKEEPER-1643)

The original patch: <https://github.com/apache/zookeeper/commit/46b565e6abd8423c43f1bb8da782d76bac7c392c>


Thanks,

Zhiwei Chen