You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/24 12:25:23 UTC

[GitHub] [incubator-nuttx] cisvanmierlo opened a new pull request, #6319: SSD1306: Added option to force reconfigure display after power off

cisvanmierlo opened a new pull request, #6319:
URL: https://github.com/apache/incubator-nuttx/pull/6319

   ## Summary
   Added option to force reconfigure the display after power off.
   This is useful if for example the voltage domain of the display is not active during NuttX initialization.
   
   ## Impact
   Extended the current kconfig options.
   
   ## Testing
   Tested on custom S32K1xx board.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] hartmannathan commented on a diff in pull request #6319: SSD1306: Added option to force reconfigure display after power off

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on code in PR #6319:
URL: https://github.com/apache/incubator-nuttx/pull/6319#discussion_r880446374


##########
drivers/lcd/Kconfig:
##########
@@ -416,6 +416,12 @@ config SSD1306_I2CFREQ
 
 endif # LCD_SSD1306_I2C
 
+config SSD1306_POWEROFF_RECONFIGURE
+	bool "Reconfigre SSD1306 after power off"

Review Comment:
   s/Reconfigre/Reconfigure/



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] cisvanmierlo commented on a diff in pull request #6319: SSD1306: Added option to force reconfigure display after power off

Posted by GitBox <gi...@apache.org>.
cisvanmierlo commented on code in PR #6319:
URL: https://github.com/apache/incubator-nuttx/pull/6319#discussion_r880459923


##########
drivers/lcd/Kconfig:
##########
@@ -416,6 +416,12 @@ config SSD1306_I2CFREQ
 
 endif # LCD_SSD1306_I2C
 
+config SSD1306_POWEROFF_RECONFIGURE
+	bool "Reconfigre SSD1306 after power off"

Review Comment:
   Good spot, thanks!
   I've fixed it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6319: SSD1306: Added option to force reconfigure display after power off

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6319:
URL: https://github.com/apache/incubator-nuttx/pull/6319


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org