[GitHub] sjanc closed pull request #15: Use a short, consistent style for prompts in Kconfig

[GitBox <gi...@apache.org>]

sjanc closed pull request #15: Use a short, consistent style for prompts in Kconfig
URL: https://github.com/apache/mynewt-mcumgr/pull/15
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/Kconfig b/Kconfig
index 15b546e..8fba521 100644
--- a/Kconfig
+++ b/Kconfig
@@ -16,8 +16,7 @@
 # under the License.
 
 config MCUMGR
-    bool
-    prompt "mcumgr Support"
+    bool "mcumgr Support"
     select TINYCBOR
     help
       This option enables the mcumgr management library.
diff --git a/cmd/fs_mgmt/Kconfig b/cmd/fs_mgmt/Kconfig
index dae3ad7..1134479 100644
--- a/cmd/fs_mgmt/Kconfig
+++ b/cmd/fs_mgmt/Kconfig
@@ -16,24 +16,21 @@
 # Under the License.
 
 menuconfig MCUMGR_CMD_FS_MGMT
-    bool
-    prompt "Enable mcumgr handlers for file management"
+    bool "Enable mcumgr handlers for file management"
     depends on FILE_SYSTEM
     help
       Enables mcumgr handlers for file management
 
 if MCUMGR_CMD_FS_MGMT
 config FS_MGMT_UL_CHUNK_SIZE
-    int
-    prompt "Maximum chunk size for file uploads"
+    int "Maximum chunk size for file uploads"
     default 512
     help
       Limits the maximum chunk size for file uploads, in bytes.  A buffer of
       this size gets allocated on the stack during handling of a file upload command.
 
 config FS_MGMT_DL_CHUNK_SIZE
-    int
-    prompt "Maximum chunk size for file downloads"
+    int "Maximum chunk size for file downloads"
     default 512
     help
       Limits the maximum chunk size for file downloads, in bytes.  A buffer of
@@ -41,8 +38,7 @@ config FS_MGMT_DL_CHUNK_SIZE
       command.
 
 config FS_MGMT_PATH_SIZE
-    int
-    prompt "Maximum file path length"
+    int "Maximum file path length"
     default 64
     help
       Limits the maximum path length for file operations, in bytes.  A buffer
diff --git a/cmd/img_mgmt/Kconfig b/cmd/img_mgmt/Kconfig
index 73f0df0..e17d043 100644
--- a/cmd/img_mgmt/Kconfig
+++ b/cmd/img_mgmt/Kconfig
@@ -16,8 +16,7 @@
 # Under the License.
 
 menuconfig MCUMGR_CMD_IMG_MGMT
-    bool
-    prompt "Enable mcumgr handlers for image management"
+    bool "Enable mcumgr handlers for image management"
     select FLASH
     select MPU_ALLOW_FLASH_WRITE if CPU_HAS_MPU
     select IMG_MANAGER
@@ -26,8 +25,7 @@ menuconfig MCUMGR_CMD_IMG_MGMT
 
 if MCUMGR_CMD_IMG_MGMT
 config IMG_MGMT_UL_CHUNK_SIZE
-    int
-    prompt "Maximum chunk size for image uploads"
+    int "Maximum chunk size for image uploads"
     default 512
     help
       Limits the maximum chunk size for image uploads, in bytes.  A buffer of
diff --git a/cmd/log_mgmt/Kconfig b/cmd/log_mgmt/Kconfig
index 201c6e0..a762cc1 100644
--- a/cmd/log_mgmt/Kconfig
+++ b/cmd/log_mgmt/Kconfig
@@ -16,23 +16,20 @@
 # Under the License.
 
 menuconfig MCUMGR_CMD_LOG_MGMT
-    bool
-    prompt "Enable mcumgr handlers for log management"
+    bool "Enable mcumgr handlers for log management"
     help
       Enables mcumgr handlers for log management
 
 if MCUMGR_CMD_LOG_MGMT
 config LOG_MGMT_CHUNK_SIZE
-    int
-    prompt "Maximum chunk size for log downloads"
+    int "Maximum chunk size for log downloads"
     default 512
     help
       Limits the maximum chunk size for log downloads, in bytes.  A buffer of
       this size gets allocated on the stack during handling of the log show command.
 
 config LOG_MGMT_NAME_LEN
-    int
-    prompt "Maximum log name length"
+    int "Maximum log name length"
     default 64
     help
       Limits the maximum length of log names, in bytes.  If a log's name length
@@ -41,8 +38,7 @@ config LOG_MGMT_NAME_LEN
       management commands.
 
 config LOG_MGMT_BODY_LEN
-    int
-    prompt "Maximum log body length"
+    int "Maximum log body length"
     default 128
     help
       Limits the maximum length of log entry bodies, in bytes.  If a log
diff --git a/cmd/stat_mgmt/Kconfig b/cmd/stat_mgmt/Kconfig
index 9c5ae18..08bb3ec 100644
--- a/cmd/stat_mgmt/Kconfig
+++ b/cmd/stat_mgmt/Kconfig
@@ -16,16 +16,14 @@
 # Under the License.
 
 menuconfig MCUMGR_CMD_STAT_MGMT
-    bool
-    prompt "Enable mcumgr handlers for statistics management"
+    bool "Enable mcumgr handlers for statistics management"
     depends on STATS
     help
       Enables mcumgr handlers for statistics management.
 
 if MCUMGR_CMD_STAT_MGMT
 config STAT_MGMT_MAX_NAME_LEN
-    int
-    prompt "Maximum stat group name length"
+    int "Maximum stat group name length"
     default 32
     help
       Limits the maximum stat group name length in mcumgr requests, in bytes.


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services