You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/09/21 19:55:07 UTC

[GitHub] [beam] chunyang commented on a change in pull request #15536: [BEAM-12913] Enable configuration of query priority in ReadFromBigQuery

chunyang commented on a change in pull request #15536:
URL: https://github.com/apache/beam/pull/15536#discussion_r713372214



##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -1915,6 +1927,11 @@ class ReadFromBigQuery(PTransform):
         that dataset, and will remove it once it is not needed. Job needs access
         to create and delete tables within the given dataset. Dataset name
         should *not* start with the reserved prefix `beam_temp_dataset_`.
+    query_priority (BigQueryQueryPriority): By default, this transform runs

Review comment:
       This PR does make the priority BATCH by default.
   
   If you're asking about whether or not we should expose a `query_priority` parameter, I don't have strong opinions either way. My original commit (https://github.com/apache/beam/pull/15536/commits/b66e4b1361a6ccc0f5887777b0926630c7efc59e) makes it non-configurable, but after seeing that it's [configurable](https://beam.apache.org/releases/javadoc/2.32.0/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.TypedRead.html#withQueryPriority-org.apache.beam.sdk.io.gcp.bigquery.BigQueryIO.TypedRead.QueryPriority-) in the Java BigQueryIO, I decided to make the Python side consistent.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org