You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2019/12/04 18:07:23 UTC
[Impala-ASF-CR] IMPALA-9215: report benchmark results.py fails with missing key
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14830
Change subject: IMPALA-9215: report_benchmark_results.py fails with missing key
......................................................................
IMPALA-9215: report_benchmark_results.py fails with missing key
report_benchmark_results.py failed with missing key because it tried
to lookup 'num_instances' from the perf result json file. The JSON
file contained exec summary generated by
impala_beeswax.py::__build_summary_table() which omitted number of
instances.
This patch adds 'num_instances' to the summary table created by
impala_beeswax.py.
To keep report_benchmark_results.py simple it assumes that both perf
json files contain 'num_instances', i.e. if a user issues
single_node_perf_run.py to compare two commits, both of them must
contain this fix.
I tested the PS manually.
Change-Id: I822c86f621f5a348b56d672c263a2cf9321767ee
---
M tests/beeswax/impala_beeswax.py
M tests/benchmark/report_benchmark_results.py
2 files changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/14830/1
--
To view, visit http://gerrit.cloudera.org:8080/14830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I822c86f621f5a348b56d672c263a2cf9321767ee
Gerrit-Change-Number: 14830
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9215: report benchmark results.py fails with missing key
Posted by "Norbert Luksa (Code Review)" <ge...@cloudera.org>.
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14830 )
Change subject: IMPALA-9215: report_benchmark_results.py fails with missing key
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/14830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I822c86f621f5a348b56d672c263a2cf9321767ee
Gerrit-Change-Number: 14830
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Dec 2019 08:13:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9215: report benchmark results.py fails with missing key
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14830 )
Change subject: IMPALA-9215: report_benchmark_results.py fails with missing key
......................................................................
IMPALA-9215: report_benchmark_results.py fails with missing key
report_benchmark_results.py failed with missing key because it tried
to lookup 'num_instances' from the perf result json file. The JSON
file contained exec summary generated by
impala_beeswax.py::__build_summary_table() which omitted number of
instances.
This patch adds 'num_instances' to the summary table created by
impala_beeswax.py.
To keep report_benchmark_results.py simple it assumes that both perf
json files contain 'num_instances', i.e. if a user issues
single_node_perf_run.py to compare two commits, both of them must
contain this fix.
I tested the PS manually.
Change-Id: I822c86f621f5a348b56d672c263a2cf9321767ee
Reviewed-on: http://gerrit.cloudera.org:8080/14830
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/beeswax/impala_beeswax.py
M tests/benchmark/report_benchmark_results.py
2 files changed, 6 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I822c86f621f5a348b56d672c263a2cf9321767ee
Gerrit-Change-Number: 14830
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
[Impala-ASF-CR] IMPALA-9215: report benchmark results.py fails with missing key
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14830 )
Change subject: IMPALA-9215: report_benchmark_results.py fails with missing key
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5197/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I822c86f621f5a348b56d672c263a2cf9321767ee
Gerrit-Change-Number: 14830
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Dec 2019 18:36:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9215: report benchmark results.py fails with missing key
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14830 )
Change subject: IMPALA-9215: report_benchmark_results.py fails with missing key
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I822c86f621f5a348b56d672c263a2cf9321767ee
Gerrit-Change-Number: 14830
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Dec 2019 17:07:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9215: report benchmark results.py fails with missing key
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14830 )
Change subject: IMPALA-9215: report_benchmark_results.py fails with missing key
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I822c86f621f5a348b56d672c263a2cf9321767ee
Gerrit-Change-Number: 14830
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Dec 2019 11:01:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9215: report benchmark results.py fails with missing key
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14830 )
Change subject: IMPALA-9215: report_benchmark_results.py fails with missing key
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5314/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I822c86f621f5a348b56d672c263a2cf9321767ee
Gerrit-Change-Number: 14830
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Dec 2019 12:39:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9215: report benchmark results.py fails with missing key
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14830 )
Change subject: IMPALA-9215: report_benchmark_results.py fails with missing key
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I822c86f621f5a348b56d672c263a2cf9321767ee
Gerrit-Change-Number: 14830
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Dec 2019 12:39:41 +0000
Gerrit-HasComments: No