[GitHub] [pulsar] eolivelli commented on a change in pull request #9659: [FlakyTest]Try to fix flaky test ReplicatorTest.testReplicatorOnPartitionedTopic.

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #9659:
URL: https://github.com/apache/pulsar/pull/9659#discussion_r581036106



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/BrokerTestUtil.java
##########
@@ -0,0 +1,28 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.broker;
+
+/**
+ * Holds util methods used in test.
+ */
+public class BrokerTestUtil {
+    // Generate unique namespace name for different test run.
+    public static String newUniqueNamespace(String prefix) { return prefix + "-" + System.nanoTime(); }

Review comment:
       what about using a static `AtomicLong` variable and use `incrementAndGet` ?
   
   what about naming this method `newUniqueName` ? as we are not using it only for namespaces but also for topic names
   or we could have `newNamespaceName` and `newTopicName`
   
   nit: probably formatting is not following current coding style 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org