You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "DoChaoing (via GitHub)" <gi...@apache.org> on 2026/03/06 09:39:25 UTC
[PR] fix: duplicate columns in undo_log afterImage for composite primary key tables [incubator-seata]
DoChaoing opened a new pull request, #8013:
URL: https://github.com/apache/incubator-seata/pull/8013
### Ⅰ. Describe what this PR did
This PR fixes the issue where the in contains duplicate column entries when inserting into tables with composite primary keys.
### Ⅱ. Does this pull request fix one issue?
Fixes #8005
### Ⅲ. Why don't you add test cases (unit test/integration test)?
Existing test cases should cover this fix. The change is a logic reordering in method without changing the final output for correct cases.
### Ⅳ. Describe how to verify it
1. Create a table with composite primary key (e.g., uid=0(root) gid=0(root) groups=0(root) + )
2. Insert a record where one PK column is in the insert statement
3. Check - the should not have duplicate columns
### Ⅴ. Special notes for reviewers
**Root Cause:**
The original code added primary key columns first, then insert columns. When a PK column was already in the insert statement, it would be added twice.
**Fix:**
Reorder the logic to:
1. First add insert columns
2. Then add only missing primary key columns
This ensures no duplicates while still including all necessary columns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: duplicate columns in undo_log afterImage for composite primary key tables [incubator-seata]
Posted by "DoChaoing (via GitHub)" <gi...@apache.org>.
DoChaoing closed pull request #8013: fix: duplicate columns in undo_log afterImage for composite primary key tables
URL: https://github.com/apache/incubator-seata/pull/8013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: duplicate columns in undo_log afterImage for composite primary key tables [incubator-seata]
Posted by "lbj812 (via GitHub)" <gi...@apache.org>.
lbj812 commented on PR #8013:
URL: https://github.com/apache/incubator-seata/pull/8013#issuecomment-4196353374
请对 1.8.0版本进行修改
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: duplicate columns in undo_log afterImage for composite primary key tables [incubator-seata]
Posted by "lbj812 (via GitHub)" <gi...@apache.org>.
lbj812 commented on PR #8013:
URL: https://github.com/apache/incubator-seata/pull/8013#issuecomment-4196328557
对于 BaseTransactionalExecutor 类的修改，在分支2.X中不存在，还是旧代码，这是怎么回事？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org