You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Olivier Lamy (JIRA)" <ji...@codehaus.org> on 2009/03/21 22:32:13 UTC

[jira] Commented: (SCM-418) Support for Perforce changelogs in Continuum and changelog plugin

    [ http://jira.codehaus.org/browse/SCM-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=170536#action_170536 ] 

Olivier Lamy commented on SCM-418:
----------------------------------

could it be possible to have a patch with the current trunk ? I cannot apply your patch

> Support for Perforce changelogs in Continuum and changelog plugin
> -----------------------------------------------------------------
>
>                 Key: SCM-418
>                 URL: http://jira.codehaus.org/browse/SCM-418
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-perforce
>    Affects Versions: 1.1
>         Environment: tested on Maven 2.0.9, Continuum 1.2, Perforce 2008.1, all under Fedora 9
>            Reporter: Peter Janes
>         Attachments: changelog.patch
>
>
> Continuum wasn't reporting author/date/comment for each build's modified files when used with Perforce.  I tracked the root cause to the update command not returning the current changelist, which in turn wasn't being provided to the changelog command.  At the same time, the changelog command didn't accept revision-based ranges, only dates.
> The attached patch (with updated test cases) makes the Continuum build status pages return full results.
> The basic flow is to get the newly-submitted changelist numbers using "p4 changes", then populate ChangeSet objects directly using "p4 describe".
> A side effect is that this replaces the patch for SCM-332.  The original code gathered the changed files (and their comments) with "p4 filelog", which the patch then re-aggregated into changesets.  The new version accomplishes the same thing, but more directly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira