You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "squakez (via GitHub)" <gi...@apache.org> on 2024/01/05 10:20:06 UTC
[I] Make healt trait as default [camel-k]
squakez opened a new issue, #5024:
URL: https://github.com/apache/camel-k/issues/5024
### Requirement
Considering the issue reported in #4977 and the improvements done in the monitoring, I wonder if we should enable by default the health trait. Right now, it's disabled by default, but I think we should change the behavior in order to have a more reliable experience when starting up an Integration which should be able to check at least the readiness probe before turning the Integration as running.
### Problem
a
### Proposal
_No response_
### Open questions
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Make healt trait as default [camel-k]
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on issue #5024:
URL: https://github.com/apache/camel-k/issues/5024#issuecomment-1878557749
That looks like a good idea but I wonder how would we work the default probe path on non-quarkus runtime ? As it is activating by default the health trait mean having readiness and liveness active by default. For now the default probe path are hard-coded here : https://github.com/apache/camel-k/blob/cae9e899510656f71fecc0131cc8a0aaf6e8fcfe/pkg/trait/health.go#L34-L36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Make healt trait as default [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on issue #5024:
URL: https://github.com/apache/camel-k/issues/5024#issuecomment-1878438936
@lburgazzoli wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Make healt trait as default [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez closed issue #5024: Make healt trait as default
URL: https://github.com/apache/camel-k/issues/5024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Make healt trait as default [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on issue #5024:
URL: https://github.com/apache/camel-k/issues/5024#issuecomment-1878573861
In theory we should be safe as those endpoints should be exposed by Camel regardless the runtime used. I'd expect their availability also on non Quarkus runtimes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Make healt trait as default [camel-k]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on issue #5024:
URL: https://github.com/apache/camel-k/issues/5024#issuecomment-1880565765
@squakez I think it makes a lot of sense
@gansheer you are right, as today camel-k assumes the runtime is quarkus hence the health endpoint path is hard-coded to the quarkus default one so once we add support for an additional runtime, then we have to make those path runtime dependant.
As a side note, we should start supporeting/sugin the quarkus/spring-boot management port for non "business" traffic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Make healt trait as default [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on issue #5024:
URL: https://github.com/apache/camel-k/issues/5024#issuecomment-2084739936
> * It seems that the health is affecting the execution of cron (or the test which result in error). I don't have yet a clear understanding of what's happening.
The problem with the cron is the fact that our test is very quick to execute, therefore, the Pod is finished before reaching the Ready state. Maybe it makes sense that our tests have some artificial delay in order to simulate a workload that is above the few millis required to print a text to output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Make healt trait as default [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on issue #5024:
URL: https://github.com/apache/camel-k/issues/5024#issuecomment-2082919713
Enabling this trait by default (with readiness probe only) would have the following side effects [1]:
* Debug feature is not working, so, we should disable the trait explicitly when running in debug mode
* An errored route would be never in ready state (that should be fine, but we have tests that are checking the Integration is running and is logging certain errors)
* It seems that the health is affecting the execution of cron (or the test which result in error). I don't have yet a clear understanding of what's happening.
* It is affecting the master trait (here maybe for good as it seems that the switch from a Pod to another is immediate, so, only the test may require some attention)
[1] https://github.com/apache/camel-k/actions/runs/8849672619?pr=5096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Make healt trait as default [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on issue #5024:
URL: https://github.com/apache/camel-k/issues/5024#issuecomment-2115460951
We must reopen this because it turned out the change would be a breaking compatibility one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org