[GitHub] [openwhisk] ningyougang commented on a change in pull request #4790: Add administrative interface to invoker and controller to reconfigure runtimes

[GitBox <gi...@apache.org>]

ningyougang commented on a change in pull request #4790:
URL: https://github.com/apache/openwhisk/pull/4790#discussion_r436566835



##########
File path: core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala
##########
@@ -302,6 +307,33 @@ class ContainerPool(childFactory: ActorRefFactory => ActorRef,
     case RescheduleJob =>
       freePool = freePool - sender()
       busyPool = busyPool - sender()
+    case prewarmConfigList: PreWarmConfigList =>
+      val passedPrewarmConfig = prewarmConfigList.list
+      var newPrewarmConfig: List[PrewarmingConfig] = List.empty
+      latestPrewarmConfig foreach { config =>
+        newPrewarmConfig = newPrewarmConfig :+ passedPrewarmConfig
+          .find(passedConfig =>
+            passedConfig.exec.kind == config.exec.kind && passedConfig.memoryLimit == config.memoryLimit)
+          .getOrElse(config)
+      }
+      latestPrewarmConfig = newPrewarmConfig

Review comment:
       Support just change specify runtime config, e.g.
   Let's assume runtimes.json include nodejs:12, python:2, swift4.1, we can change nodejs:12 runtime only via `just pass nodejs:12 runtime info`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org