You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Alan Woodward (JIRA)" <ji...@apache.org> on 2019/03/14 10:31:00 UTC

[jira] [Commented] (LUCENE-8726) WrappedDoubleValuesSource can leak IndexSearcher references

    [ https://issues.apache.org/jira/browse/LUCENE-8726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792528#comment-16792528 ] 

Alan Woodward commented on LUCENE-8726:
---------------------------------------

Patch, similar to the one on SOLR-13315 but with some added javadocs.

> WrappedDoubleValuesSource can leak IndexSearcher references
> -----------------------------------------------------------
>
>                 Key: LUCENE-8726
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8726
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Major
>         Attachments: LUCENE-8726.patch
>
>
> Cause of SOLR-13315
> Index-specific DoubleValuesSources can be created by DoubleValuesSource.rewrite(), and the various consumers of these sources are careful not to store these rewritten sources on long-lived objects, such as queries that may be re-used between searchers.  However, the bridge code between ValueSource and DoubleValuesSource does not return a new object from its rewrite method, instead caching the passed-in IndexSearcher, which means references to this searcher may leak.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org