[jira] [Commented] (YUNIKORN-1746) Improve the performance of nodeInfoListerImpl.List()

["Peter Bacsko (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YUNIKORN-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17723551#comment-17723551 ] 

Peter Bacsko commented on YUNIKORN-1746:
----------------------------------------

Example performance data

!screenshot-1.png! 
!screenshot-2.png! 

> Improve the performance of nodeInfoListerImpl.List()
> ----------------------------------------------------
>
>                 Key: YUNIKORN-1746
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1746
>             Project: Apache YuniKorn
>          Issue Type: Sub-task
>            Reporter: Peter Bacsko
>            Assignee: Peter Bacsko
>            Priority: Major
>         Attachments: screenshot-1.png, screenshot-2.png
>
>
> Performance data (cpu and heap profiles) indicate that we can improve the performance of {{nodeInfoListerImpl.List()}}.
> This is the code which is located in the shim:
> {noformat}
> func (n nodeInfoListerImpl) List() ([]*framework.NodeInfo, error) {
> 	nodes := n.cache.GetNodesInfoMap()
> 	nodeList := make([]*framework.NodeInfo, 0, len(nodes))
> 	for _, node := range nodes {
> 		nodeList = append(nodeList, node)
> 	}
> 	return nodeList, nil
> }
> {noformat}
> We're supposed to be having a read lock on the cache, which is done outside this method. 
> The problem is, the nodes info map only changes if a node joins or leaves the cluster. A lot of copying is done here, we generate a lot of waste. This method is called very frequently, because predicates need this list and predicates always run for each pod by default.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org