You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2007/05/09 03:39:56 UTC
[Bug 5454] New: sa-update fails with "score set for non-existent rule" messages
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5454
Summary: sa-update fails with "score set for non-existent rule"
messages
Product: Spamassassin
Version: unspecified
Platform: Other
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P5
Component: sa-update
AssignedTo: dev@spamassassin.apache.org
ReportedBy: flameeyes@gmail.com
After upgrade to SpamAssassin 3.2.0-r1 in Gentoo, the sa-update script does
not work anymore with the default update channel. It outputs the messages I'm
going to attach, that are mostly a long set of "warning: score set for
non-existent rule".
The problem seems to be for all the rules present in the 72_active.cf file
that gets their score assigned in 50_scores.pf. I'm tempted in saying that the
cause might be related to bug #5371.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5454] sa-update fails with "score set for non-existent rule" messages
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5454
------- Additional Comments From flameeyes@gmail.com 2007-05-09 06:16 -------
Explicitely loading Mail::SpamAssassin::Plugin::URIDNSBL does not seem to
change the output of sa-update (although spamassassin --lint shows it being
loaded); also patching the system-installed 50_scores.cf file won't solve
anything, I suppose it should be patched in the updated files.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5454] sa-update fails with "score set for non-existent rule" messages
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5454
------- Additional Comments From schuster.sven@gmx.de 2007-05-10 05:45 -------
Created an attachment (id=3941)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3941&action=view)
Proposed fix for bug #5454
Make lint not fail when there are score sets/descriptions for non-existant
rules
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5454] sa-update fails with "score set for non-existent rule" messages
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5454
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dev@spamassassin.apache.org
AssignedTo|dev@spamassassin.apache.org |spamassassin@dostech.ca
------- Additional Comments From spamassassin@dostech.ca 2007-05-10 09:42 -------
(In reply to comment #5)
> We need to fix this ASAP, since the update is broken for people who have disabled
> some of the default plugin set.
I'll be pushing an update later today to fix the 2 missing ifplugins in
72_scores.cf and the 102 (yes 102!) in the base release's 50_scores.cf.
> these are the default-active plugins, and the ones that the update currently
> requires.
The base release too! :(
(In reply to comment #11)
> yep, that would do it. Note though that while I think it makes sense for this
> to be a non-lint-error situation, others may disagree ;) let's see.
Yeah, I don't like that. The rule update is broken, not the software. If we
were to ignore the "score set for non-existent rule" lint errors, running a
normal "spamassassin --lint" on the system would fail -- quite possibly causing
problems with other things going on on that system.
If we're going to do anything, I'd add a --forceupdate option which would
install an update no matter how badly it fails to lint. I'm a indifferent to
actually adding it though. If it is added it needs to note that --forceupdate
was used in a comment in the channel .cf file (that includes all the rule files)
so that there's something to point at when somebody goes "hey, why'd your crappy
update screw up my install".
> (Also we'd still have to do the long-term fix -- some code to ensure that
> "ifplugin" lines are added to scores files in updates -- anyway.)
Working on it. I've got management meetings the rest of the day though, so
it'll be sometime this evening before I get an update done (I had prepared one
by hand to fix the 2 missing ifplugin lines in 72_scores.cf then noticed the 102
missing ones in 50_scores.cf so I scraped the by hand idea).
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are on the CC list for the bug, or are watching someone who is.
[Bug 5454] sa-update fails with "score set for non-existent rule" messages
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5454
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From spamassassin@dostech.ca 2007-05-10 23:47 -------
Hmm, no where near that many in the actual release are broken, I'm not sure how
trunk and the 3.2 release got that far out of sync.
Anyway... bug 5436 was already opened about ifplugin issues in the 3.2.0
release. Closing this as fixed.
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 5454] sa-update fails with "score set for non-existent rule" messages
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5454
------- Additional Comments From schuster.sven@gmx.de 2007-05-10 05:47 -------
Sorry, new to bugzilla :)
Something like the previously attached patch??
Tested on my local installation. sa-update correctly completes with
this test and some plugins disabled.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5454] sa-update fails with "score set for non-existent rule" messages
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5454
------- Additional Comments From jm@jmason.org 2007-05-09 05:43 -------
aha, you don't have Mail::SpamAssassin::Plugin::URIDNSBL loaded, and the rules
that require that plugin do not have their score lines protected with "ifplugin".
that's bug 5436, and there's a fix for that file that'll be in 3.2.1.
however there are also others from the update's "72_scores.cf" file, such as:
config: warning: score set for non-existent rule FRT_OPPORTUN1
this is a MIMEHeader rule, added in the update, which again has a plugin
requirement but no ifplugin line in the update's generated scores file. We need
to fix this in Daryl's score-generation-for-updates code, hence this is a
separate bug from 5436.
(I think we generally need some kind of script that takes a scores file and a
set of rules files, figures out which rules require which "ifplugin" lines, and
outputs a modified version of the scores file with the ifplugin lines added. not
simple, unfortunately...)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5454] sa-update fails with "score set for non-existent rule" messages
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5454
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |major
Priority|P5 |P1
Target Milestone|Undefined |3.2.1
Version|unspecified |3.2.0
------- Additional Comments From jm@jmason.org 2007-05-10 03:49 -------
We need to fix this ASAP, since the update is broken for people who have disabled
some of the default plugin set.
Diego: in the short term, if you re-enable *all* of the following plugins (not
just URIDNSBL) it should work again:
Mail::SpamAssassin::Plugin::URIDNSBL
Mail::SpamAssassin::Plugin::Hashcash
Mail::SpamAssassin::Plugin::Pyzor
Mail::SpamAssassin::Plugin::AWL
Mail::SpamAssassin::Plugin::AutoLearnThreshold
Mail::SpamAssassin::Plugin::WhiteListSubject
Mail::SpamAssassin::Plugin::MIMEHeader
Mail::SpamAssassin::Plugin::ReplaceTags
these are the default-active plugins, and the ones that the update currently
requires.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5454] sa-update fails with "score set for non-existent rule" messages
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5454
------- Additional Comments From jm@jmason.org 2007-05-10 05:58 -------
yep, that would do it. Note though that while I think it makes sense for this
to be a non-lint-error situation, others may disagree ;) let's see.
(Also we'd still have to do the long-term fix -- some code to ensure that
"ifplugin" lines are added to scores files in updates -- anyway.)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5454] sa-update fails with "score set for non-existent rule" messages
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5454
------- Additional Comments From schuster.sven@gmx.de 2007-05-10 04:27 -------
Hmm...one more thought: why should this "error" make sa-update fail at all??
Why can't this one just be a warning which will be output but not make it
fail?? At least as a short-term solution until something better is in place
(e.g. figuring out the proper "ifplugin" lines, see comment #3 from jm)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5454] sa-update fails with "score set for non-existent rule" messages
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5454
------- Additional Comments From flameeyes@gmail.com 2007-05-09 04:01 -------
Created an attachment (id=3939)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3939&action=view)
sa-update-log
3.2.0-r1 is like RPM's 3.2.0-1 or Debian's 3.2.0_1, it's an internal revision
count; shouldn't be a problem, the -r1 was only to add a dependency over re2c
that was missing the first time around.
I have attached the output, hopefully it will help diagnosing the problem.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5454] sa-update fails with "score set for non-existent rule" messages
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5454
------- Additional Comments From jm@jmason.org 2007-05-09 03:25 -------
can you run "sa-update --debug" and attach the entire output?
BTW there is no 3.2.0-r1. Do you mean 3.2.0-rc1? or has Gentoo
invented a new version? ;)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5454] sa-update fails with "score set for non-existent rule" messages
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5454
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO| |5171
nThis| |
------- Additional Comments From jm@jmason.org 2007-05-10 03:51 -------
this is related to bug 5171, btw
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5454] sa-update fails with "score set for non-existent rule" messages
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5454
------- Additional Comments From schuster.sven@gmx.de 2007-05-10 06:46 -------
(In reply to comment #11)
> (Also we'd still have to do the long-term fix -- some code to ensure that
> "ifplugin" lines are added to scores files in updates -- anyway.)
yes of course, the patch is only kind of an emergency solution for now, with
the real one being to correct the rule generation.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5454] sa-update fails with "score set for non-existent rule" messages
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5454
------- Additional Comments From jm@jmason.org 2007-05-10 05:07 -------
good point Sven.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5454] sa-update fails with "score set for non-existent rule" messages
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5454
------- Additional Comments From spamassassin@dostech.ca 2007-05-10 23:31 -------
OK, update 535132 contains all the required ifplugin lines.
However, the 50_scores.cf file included in 3.2.0 itself has about 100 score
lines that are missing ifplugin lines too (there were only 2 rules in the update
missing ifplugin lines).
Leaving this open so I remember to fix 50_scores.cf in the 3.2 branch.
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.