[jira] [Closed] (ORC-897) optimization loop termination condition in readerIsCompatible method

["William Hyun (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ORC-897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

William Hyun closed ORC-897.
----------------------------

> optimization loop termination condition in readerIsCompatible method
> --------------------------------------------------------------------
>
>                 Key: ORC-897
>                 URL: https://issues.apache.org/jira/browse/ORC-897
>             Project: ORC
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 1.8.0
>            Reporter: Yiqun Zhang
>            Assignee: Yiqun Zhang
>            Priority: Trivial
>             Fix For: 1.8.0
>
>
> {code:java}
>   private static boolean sameKeys(EncryptionKey[] first,
>                                   EncryptionKey[] next) {
>     if (first.length != next.length) {
>       return false;
>     }
>     for(int k = 0; k < first.length && k < next.length; ++k) {
>       if (!first[k].getKeyName().equals(next[k].getKeyName()) ||
>           first[k].getKeyVersion() != next[k].getKeyVersion() ||
>           first[k].getAlgorithm() != next[k].getAlgorithm()) {
>         return false;
>       }
>     }
>     return true;
>   }
> {code}
> {color:red}k < next.length{color} is not necessary
> There are five similar codes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)