You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "aswathitv (via GitHub)" <gi...@apache.org> on 2025/05/27 12:18:28 UTC
[PR] Moving or resizing a Decision contained by a Decision Service [incubator-kie-tools]
aswathitv opened a new pull request, #3157:
URL: https://github.com/apache/incubator-kie-tools/pull/3157
Closes [kie#889](https://github.com/apache/incubator-kie-issues/issues/889)
- Resizing a decision contained by decision service resizes the decision in all decision services in DRDs
- Moving a decision contained by decision service moves the decision in all decision services in DRDs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#889: DMN Editor: Moving or resizing a Decision contained by a Decision Service [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento merged PR #3157:
URL: https://github.com/apache/incubator-kie-tools/pull/3157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#889: DMN Editor: Moving or resizing a Decision contained by a Decision Service [incubator-kie-tools]
Posted by "aswathitv (via GitHub)" <gi...@apache.org>.
aswathitv commented on code in PR #3157:
URL: https://github.com/apache/incubator-kie-tools/pull/3157#discussion_r2110823998
##########
packages/dmn-editor/src/diagram/Diagram.tsx:
##########
@@ -867,6 +893,32 @@ export const Diagram = React.forwardRef<DiagramRef, { container: React.RefObject
});
}
}
+ if (node.type === NODE_TYPES.decision && node.data.parentRfNode) {
+ const parentDS = node.data.parentRfNode;
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#889: DMN Editor: Moving or resizing a Decision contained by a Decision Service [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on code in PR #3157:
URL: https://github.com/apache/incubator-kie-tools/pull/3157#discussion_r2109785508
##########
packages/dmn-editor/src/diagram/Diagram.tsx:
##########
@@ -867,6 +893,32 @@ export const Diagram = React.forwardRef<DiagramRef, { container: React.RefObject
});
}
}
+ if (node.type === NODE_TYPES.decision && node.data.parentRfNode) {
+ const parentDS = node.data.parentRfNode;
Review Comment:
```suggestion
const parentDecisionService = node.data.parentRfNode;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#889: DMN Editor: Moving or resizing a Decision contained by a Decision Service [incubator-kie-tools]
Posted by "aswathitv (via GitHub)" <gi...@apache.org>.
aswathitv commented on PR #3157:
URL: https://github.com/apache/incubator-kie-tools/pull/3157#issuecomment-2918485348
@jomarko This issue is because we have not incorporated resizing of decision service in this ticket. Here it covers resizing of decision and repositioning of decision inside decision service
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org