[jira] [Commented] (WW-3462) connection open after report generation

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WW-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379422#comment-15379422 ] 

Hudson commented on WW-3462:
----------------------------

SUCCESS: Integrated in Struts-JDK7-master #495 (See [https://builds.apache.org/job/Struts-JDK7-master/495/])
Patch WW-3462 (lukaszlenart: rev 9420789862ffe073b05a5028aa792d160e334918)
* plugins/jasperreports/src/main/java/org/apache/struts2/views/jasperreports/JasperReportsResult.java


> connection open after report generation
> ---------------------------------------
>
>                 Key: WW-3462
>                 URL: https://issues.apache.org/jira/browse/WW-3462
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - JasperReports
>    Affects Versions: 2.1.8
>         Environment: jdk1.5.0_16 
>            Reporter: Salva
>             Fix For: 2.3.28, 2.5
>
>   Original Estimate: 20m
>  Remaining Estimate: 20m
>
> If a report generation was called with connection like following code, database connection will not be closed. I suggest to modify doExecute method of org.apache.struts2.views.jasperreports.JasperReportsResult class after the exportReportToBytes, by adding, in case of conn not null, the conn closing.
> struts.xml
> ...
> <action name="report" class="myorg.actions.tests.Report">
>     <result name="success" type="jasper">
>         <param name="location">/test/Report.jasper</param>
>         <param name="connection">myConnection</param>
>         <param name="contentDisposition">attachment</param>
>         <param name="format">PDF</param>
>     </result>
> </action>
> ....
> Action execute method code
> ...
> DataSource ds = (DataSource) ictx.lookup("java:jdbc/myApp");
> myConnection = ds.getConnection();
> ...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)