You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Jukka Zitting (JIRA)" <ji...@apache.org> on 2013/05/30 12:43:20 UTC
[jira] [Updated] (OAK-709) Consider moving permission evaluation to
the node state level
[ https://issues.apache.org/jira/browse/OAK-709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated OAK-709:
------------------------------
Attachment: 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch
bq. For my understanding, instead of obtaining a builder from a secure node state, we would then obtain a secure builder from a non secure node state in RootImpl!?
Essentially, yes. See the attached patch for a quick draft.
The main problem here is the one highlighted by the ShadowInvisibleContentTest class, i.e. if the builder uses the SecurityContext as-is, new content added on top of hidden subtrees would just disappear as the SecurityContext would still consider those subtrees as read-protected. Adding an isNew() call to the visibility check should fix that, but I'll still need to work on the details. See also the TODO on SecureNodeBuidler.isNew().
> Consider moving permission evaluation to the node state level
> -------------------------------------------------------------
>
> Key: OAK-709
> URL: https://issues.apache.org/jira/browse/OAK-709
> Project: Jackrabbit Oak
> Issue Type: Sub-task
> Components: core
> Reporter: angela
> Attachments: 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch, 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch, 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch, 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch, 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch, OAK-709_2.patch, OAK-709_3.patch, OAK-709_4.patch, OAK-709-equals_hack.patch, OAK-709.patch, OAK-709-shadowing_nodes.patch, SecureNodeState.java
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira