You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/10 00:41:20 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24041: [SPARK-27119][SQL] Do not infer schema when reading Hive serde table with native data source

dongjoon-hyun commented on a change in pull request #24041: [SPARK-27119][SQL] Do not infer schema when reading Hive serde table with native data source
URL: https://github.com/apache/spark/pull/24041#discussion_r264019602
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -596,7 +597,7 @@ object SQLConf {
     .stringConf
     .transform(_.toUpperCase(Locale.ROOT))
     .checkValues(HiveCaseSensitiveInferenceMode.values.map(_.toString))
-    .createWithDefault(HiveCaseSensitiveInferenceMode.INFER_AND_SAVE.toString)
+    .createWithDefault(HiveCaseSensitiveInferenceMode.NEVER_INFER.toString)
 
 Review comment:
   +1 for the comments; 1) update the config description at line 592 ~ 593 and 2) `sql-migration-guide-upgrade.md`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org