You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/08/23 16:42:53 UTC
[GitHub] [buildstream] ssssam opened a new pull request, #1738: doc/source/hacking: Document wheel building infrastructure
ssssam opened a new pull request, #1738:
URL: https://github.com/apache/buildstream/pull/1738
There is a lot to remember in terms of wheel building, this is an
attempt to write it all down before I forget.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on a diff in pull request #1738: doc/source/hacking: Document wheel building infrastructure
Posted by GitBox <gi...@apache.org>.
gtristan commented on code in PR #1738:
URL: https://github.com/apache/buildstream/pull/1738#discussion_r1018145440
##########
doc/source/hacking/updating_python_deps.rst:
##########
@@ -20,3 +20,89 @@ changing the ``.in`` file, run the following to update the matching ``.txt``
file::
make -C requirements
+
+Adding support for a new Python release
+---------------------------------------
+
+When a new stable release of Python 3 appears, we must explicitly declare
+our support for it in the following places.
+
+tox.ini
+~~~~~~~
+
+The ``tox.ini`` file defines the environments where the BuildStream test suite
+runs. Every ``py{3.x,3.y}`` list must be updated to contain the new version
+number such as ``311`` for CPython 3.11.
+
+Use ``tox -e py311-nocover`` to run the test suite with the new version of
+Python.
+
+pyproject.toml
Review Comment:
Good addition to the hacking !
note that here we also have to bump the minimum required version of cython which includes support for the new cpython version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] ssssam commented on a diff in pull request #1738: doc/source/hacking: Document wheel building infrastructure
Posted by GitBox <gi...@apache.org>.
ssssam commented on code in PR #1738:
URL: https://github.com/apache/buildstream/pull/1738#discussion_r1018244898
##########
doc/source/hacking/updating_python_deps.rst:
##########
@@ -20,3 +20,89 @@ changing the ``.in`` file, run the following to update the matching ``.txt``
file::
make -C requirements
+
+Adding support for a new Python release
+---------------------------------------
+
+When a new stable release of Python 3 appears, we must explicitly declare
+our support for it in the following places.
+
+tox.ini
+~~~~~~~
+
+The ``tox.ini`` file defines the environments where the BuildStream test suite
+runs. Every ``py{3.x,3.y}`` list must be updated to contain the new version
+number such as ``311`` for CPython 3.11.
+
+Use ``tox -e py311-nocover`` to run the test suite with the new version of
+Python.
+
+pyproject.toml
Review Comment:
i see, and i assume this is a change request so will push an update when I have a chance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on a diff in pull request #1738: doc/source/hacking: Document wheel building infrastructure
Posted by GitBox <gi...@apache.org>.
gtristan commented on code in PR #1738:
URL: https://github.com/apache/buildstream/pull/1738#discussion_r1018295330
##########
doc/source/hacking/updating_python_deps.rst:
##########
@@ -20,3 +20,89 @@ changing the ``.in`` file, run the following to update the matching ``.txt``
file::
make -C requirements
+
+Adding support for a new Python release
+---------------------------------------
+
+When a new stable release of Python 3 appears, we must explicitly declare
+our support for it in the following places.
+
+tox.ini
+~~~~~~~
+
+The ``tox.ini`` file defines the environments where the BuildStream test suite
+runs. Every ``py{3.x,3.y}`` list must be updated to contain the new version
+number such as ``311`` for CPython 3.11.
+
+Use ``tox -e py311-nocover`` to run the test suite with the new version of
+Python.
+
+pyproject.toml
Review Comment:
I didn’t notice how old this was, don’t worry I’ll do it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] jjardon commented on pull request #1738: doc/source/hacking: Document wheel building infrastructure
Posted by GitBox <gi...@apache.org>.
jjardon commented on PR #1738:
URL: https://github.com/apache/buildstream/pull/1738#issuecomment-1308844579
This looks good to me: @gtristan @abderrahim @juergbi ok to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan merged pull request #1738: doc/source/hacking: Document wheel building infrastructure
Posted by GitBox <gi...@apache.org>.
gtristan merged PR #1738:
URL: https://github.com/apache/buildstream/pull/1738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org