You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/12/10 06:58:39 UTC
[GitHub] [iotdb-web-workbench] jakiuncle opened a new pull request, #39: feat: add support for Casdoor authentication
jakiuncle opened a new pull request, #39:
URL: https://github.com/apache/iotdb-web-workbench/pull/39
## What is the purpose of the change
add support for Casdoor authentication
Use [Casdoor](https://github.com/casdoor/casdoor) for auth.
Features:
Support OIDC, OAuth 2.0, SAML, LDAP
With [Casbin](https://casbin.org/) based authorization management, Casdoor supports ACL, RBAC, ABAC, RESTful accessing control models
Front-end and back-end separate architecture, Casdoor supports high concurrency, provides web-based managing UI and have mature solution for springboot project https://casdoor.org/docs/integration/spring-boot
Casdoor supports Github, Google, QQ, WeChat third-party applications login, and support the extension of third-party login with plugins.
Phone verification code, email verification code and forget password features.
Accessing logs auditing and recording.
Casdoor supports integration with existing systems using db sync method, users can transition to Casdoor smoothly.
Casdoor supports mainstream databases: MySQL, PostgreSQL, SQL Server etc, and support the extension of new database with plugins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb-web-workbench] jakiuncle commented on pull request #39: feat: add support for Casdoor authentication
Posted by GitBox <gi...@apache.org>.
jakiuncle commented on PR #39:
URL: https://github.com/apache/iotdb-web-workbench/pull/39#issuecomment-1356771334
@CritasWang plz review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb-web-workbench] jixuan1989 commented on a diff in pull request #39: feat: add support for Casdoor authentication
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on code in PR #39:
URL: https://github.com/apache/iotdb-web-workbench/pull/39#discussion_r1045160457
##########
backend/src/main/resources/application.properties:
##########
@@ -18,4 +18,40 @@
#
# Designate the configuration file
-spring.profiles.active=dev
\ No newline at end of file
+spring.profiles.active=dev
+
+casdoor.endpoint = http://localhost:7001
+casdoor.clientId = bba8e8be178cd1fb9b17
+casdoor.clientSecret = a0790543e686c5ce8bcaa6609005da14ac41a9a2
+casdoor.certificate =\
Review Comment:
pls leave empty as this is an open source project, rather than in a specific environment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb-web-workbench] CritasWang commented on a diff in pull request #39: feat: add support for Casdoor authentication
Posted by GitBox <gi...@apache.org>.
CritasWang commented on code in PR #39:
URL: https://github.com/apache/iotdb-web-workbench/pull/39#discussion_r1048162930
##########
frontend/src/i18n/en.js:
##########
@@ -85,6 +85,7 @@ const en = {
placeholderPassword: 'Please Input Password',
forgetPassWord: 'Forget Password',
signIn: 'Sign In',
+ signInWithCasdoor: 'sign In With Casdoor',
Review Comment:
sign -> Sign
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb-web-workbench] qiaojialin merged pull request #39: feat: add support for Casdoor authentication
Posted by GitBox <gi...@apache.org>.
qiaojialin merged PR #39:
URL: https://github.com/apache/iotdb-web-workbench/pull/39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb-web-workbench] jakiuncle commented on pull request #39: feat: add support for Casdoor authentication
Posted by GitBox <gi...@apache.org>.
jakiuncle commented on PR #39:
URL: https://github.com/apache/iotdb-web-workbench/pull/39#issuecomment-1345159832
@qiaojialin @jixuan1989 @JulianFeinauer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb-web-workbench] jakiuncle commented on a diff in pull request #39: feat: add support for Casdoor authentication
Posted by GitBox <gi...@apache.org>.
jakiuncle commented on code in PR #39:
URL: https://github.com/apache/iotdb-web-workbench/pull/39#discussion_r1048457791
##########
frontend/src/i18n/en.js:
##########
@@ -85,6 +85,7 @@ const en = {
placeholderPassword: 'Please Input Password',
forgetPassWord: 'Forget Password',
signIn: 'Sign In',
+ signInWithCasdoor: 'sign In With Casdoor',
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb-web-workbench] jakiuncle commented on a diff in pull request #39: feat: add support for Casdoor authentication
Posted by GitBox <gi...@apache.org>.
jakiuncle commented on code in PR #39:
URL: https://github.com/apache/iotdb-web-workbench/pull/39#discussion_r1045186028
##########
backend/src/main/resources/application.properties:
##########
@@ -18,4 +18,40 @@
#
# Designate the configuration file
-spring.profiles.active=dev
\ No newline at end of file
+spring.profiles.active=dev
+
+casdoor.endpoint = http://localhost:7001
+casdoor.clientId = bba8e8be178cd1fb9b17
+casdoor.clientSecret = a0790543e686c5ce8bcaa6609005da14ac41a9a2
+casdoor.certificate =\
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb-web-workbench] CritasWang commented on a diff in pull request #39: feat: add support for Casdoor authentication
Posted by GitBox <gi...@apache.org>.
CritasWang commented on code in PR #39:
URL: https://github.com/apache/iotdb-web-workbench/pull/39#discussion_r1048165670
##########
frontend/src/views/Login/index.vue:
##########
@@ -60,6 +60,9 @@
<el-button class="submit-btn" type="primary" @click="submitForm('ruleForm')">{{ $t('loginPage.signIn') }}</el-button>
</el-form-item>
</el-form>
+ <el-form-item>
+ <el-button class="submit-btn" type="primary" @click="getLoginUrl()">{{ $t('loginPage.signInWithCasdoor') }}</el-button>
Review Comment:
please add v-if,Displayed only when casdoor is enabled
##########
frontend/src/views/Login/index.vue:
##########
@@ -60,6 +60,9 @@
<el-button class="submit-btn" type="primary" @click="submitForm('ruleForm')">{{ $t('loginPage.signIn') }}</el-button>
</el-form-item>
</el-form>
+ <el-form-item>
+ <el-button class="submit-btn" type="primary" @click="getLoginUrl()">{{ $t('loginPage.signInWithCasdoor') }}</el-button>
Review Comment:
@jakiuncle Please add a casdoor on-off, The button is not display when the on-off is off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org