You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/11/30 05:17:32 UTC

[GitHub] wu-sheng commented on a change in pull request #1981: add system env for trace ignore plugin

wu-sheng commented on a change in pull request #1981: add system env for trace ignore plugin
URL: https://github.com/apache/incubator-skywalking/pull/1981#discussion_r237749004
 
 

 ##########
 File path: apm-sniffer/optional-plugins/trace-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/trace/ignore/conf/IgnoreConfigInitializer.java
 ##########
 @@ -57,6 +60,18 @@ public static void initialize() throws ConfigNotFoundException, AgentPackageNotF
             configFileStream = loadConfigFromAgentFolder();
             Properties properties = new Properties();
             properties.load(configFileStream);
+            PropertyPlaceholderHelper helper =
 
 Review comment:
   @JaredTan95 Is this right usage of your util API? Could you help on review this PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services