You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@wicket.apache.org by amilor <gi...@git.apache.org> on 2016/03/08 09:00:06 UTC

[GitHub] wicket pull request: User guide - Wicket forms in detail - Input v...

GitHub user amilor opened a pull request:

    https://github.com/apache/wicket/pull/163

    User guide - Wicket forms in detail - Input value conversion - sample code fix

    TextField's variable used for regexp pattern was named `mail`, renamed to `regExpPatternTxt` for consistency.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/amilor/wicket master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/wicket/pull/163.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #163
    
----
commit 0b223545fa8f5c3a6007004b604898c486bbcaee
Author: meno <am...@users.noreply.github.com>
Date:   2016-03-08T07:51:09Z

    Update forms2_3.gdoc
    
    TextField for regexp pattern was named mail, renamed to regExpPatternTxt for consistency.

commit 24009683036234c841a7ccb2fd5a402d967de86d
Author: meno <am...@users.noreply.github.com>
Date:   2016-03-08T07:52:43Z

    Update forms2_3.gdoc
    
    typo fix

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket pull request: User guide - sample code fixes (misleading in...

Posted by martin-g <gi...@git.apache.org>.

Github user martin-g commented on the pull request:

    https://github.com/apache/wicket/pull/163#issuecomment-193767606
  
    Thanks!
    I've merged the PR but I had to squash it to be able to merge it to 6.x/7.x and now GitHub doesn't detect it as merged.
    Please close it because we don't have permissions!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket pull request: User guide - sample code fixes (misleading in...

Posted by amilor <gi...@git.apache.org>.

Github user amilor closed the pull request at:

    https://github.com/apache/wicket/pull/163


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket pull request: User guide - Wicket forms in detail - Input v...

Posted by amilor <gi...@git.apache.org>.

Github user amilor commented on the pull request:

    https://github.com/apache/wicket/pull/163#issuecomment-193664914
  
    Just to clarify, I am not simply converting spaces to tabs or vice-versa to my liking. I fix indentation when a code in one scope has different levels of indentation, which makes it hard to read.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket pull request: User guide - sample code fixes (misleading in...

Posted by amilor <gi...@git.apache.org>.

Github user amilor commented on the pull request:

    https://github.com/apache/wicket/pull/163#issuecomment-193771271
  
    Changes have been merged, closing the PR as requested.
    
    Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---