You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ph...@apache.org on 2013/05/31 18:09:56 UTC
svn commit: r1488294 - /subversion/trunk/subversion/libsvn_subr/io.c
Author: philip
Date: Fri May 31 16:09:56 2013
New Revision: 1488294
URL: http://svn.apache.org/r1488294
Log:
* subversion/libsvn_subr/io.c
(svn_io_wait_for_cmd): Add signal information to error.
Suggested by: Doug Robinson <doug.robinson{_AT_}wandisco.com>
Modified:
subversion/trunk/subversion/libsvn_subr/io.c
Modified: subversion/trunk/subversion/libsvn_subr/io.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/io.c?rev=1488294&r1=1488293&r2=1488294&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/io.c (original)
+++ subversion/trunk/subversion/libsvn_subr/io.c Fri May 31 16:09:56 2013
@@ -2804,10 +2804,23 @@ svn_io_wait_for_cmd(apr_proc_t *cmd_proc
if (exitwhy)
*exitwhy = exitwhy_val;
+ else if (APR_PROC_CHECK_SIGNALED(exitwhy_val)
+ && APR_PROC_CHECK_CORE_DUMP(exitwhy_val))
+ return svn_error_createf
+ (SVN_ERR_EXTERNAL_PROGRAM, NULL,
+ _("Process '%s' failed (exitwhy %d, signal %d, core dumped)"),
+ cmd, exitwhy_val, exitcode_val);
+ else if (APR_PROC_CHECK_SIGNALED(exitwhy_val))
+ return svn_error_createf
+ (SVN_ERR_EXTERNAL_PROGRAM, NULL,
+ _("Process '%s' failed (exitwhy %d, signal %d)"),
+ cmd, exitwhy_val, exitcode_val);
else if (! APR_PROC_CHECK_EXIT(exitwhy_val))
+ /* Don't really know what happened here. */
return svn_error_createf
(SVN_ERR_EXTERNAL_PROGRAM, NULL,
- _("Process '%s' failed (exitwhy %d)"), cmd, exitwhy_val);
+ _("Process '%s' failed (exitwhy %d, exitcode %d)"),
+ cmd, exitwhy_val, exitcode_val);
if (exitcode)
*exitcode = exitcode_val;