Re: [PR] Cherry-pick KAFKA-16230 to 3.7 branch [kafka]

["AndrewJSchofield (via GitHub)" <gi...@apache.org>]

AndrewJSchofield commented on code in PR #16951:
URL: https://github.com/apache/kafka/pull/16951#discussion_r1726990792


##########
tools/src/main/java/org/apache/kafka/tools/VerifiableConsumer.java:
##########
@@ -529,6 +530,24 @@ private static ArgumentParser argParser() {
                 .metavar("TOPIC")
                 .help("Consumes messages from this topic.");
 
+        parser.addArgument("--group-protocol")
+                .action(store())
+                .required(false)
+                .type(String.class)
+                .setDefault(ConsumerConfig.DEFAULT_GROUP_PROTOCOL)

Review Comment:
   I believe the idea is that `DEFAULT_GROUP_PROTOCOL` changes to "CONSUMER" at an AK major release boundary. That would have the side-effect that the behaviour of this code will change at that boundary, probably unexpectedly. I suggest that you set the default to one of the concrete values, rather than the config default, and then make a conscious change in this case to move it forwards to the new value. For example, you could use a default of "CLASSIC" for releases less than 4.0, and "CONSUMER" for releases 4.0 and later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org