You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/12/12 02:27:51 UTC
[GitHub] [apisix-dashboard] mscb402 opened a new pull request, #2690: chroe: optimize "allow_origins_by_regex tooltip" description
mscb402 opened a new pull request, #2690:
URL: https://github.com/apache/apisix-dashboard/pull/2690
On the Cors plugin config page, the allow_origins_by_regex help message is misleading the user.
This PR optimize "allow_origins_by_regex tooltip" description。
**Related issues**
fix/resolve #2669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2690: chore: optimize "allow_origins_by_regex tooltip" description
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2690:
URL: https://github.com/apache/apisix-dashboard/pull/2690#issuecomment-1350518296
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2690?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2690](https://codecov.io/gh/apache/apisix-dashboard/pull/2690?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (83f1033) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/a1ffd338fabf7ab0394924651449deb9727a43ba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a1ffd33) will **increase** coverage by `4.12%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #2690 +/- ##
==========================================
+ Coverage 63.85% 67.98% +4.12%
==========================================
Files 186 39 -147
Lines 7172 1040 -6132
Branches 874 268 -606
==========================================
- Hits 4580 707 -3873
+ Misses 2389 333 -2056
+ Partials 203 0 -203
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-unit-test | `?` | |
| frontend-e2e-test | `67.98% <ø> (-8.42%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2690?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2690/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `19.67% <0.00%> (-57.38%)` | :arrow_down: |
| [web/src/components/RightContent/AvatarDropdown.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2690/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1JpZ2h0Q29udGVudC9BdmF0YXJEcm9wZG93bi50c3g=) | `50.00% <0.00%> (-32.15%)` | :arrow_down: |
| [web/src/components/PanelSection/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2690/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BhbmVsU2VjdGlvbi9pbmRleC50c3g=) | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
| [...b/src/components/Plugin/UI/referer-restriction.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2690/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9yZWZlcmVyLXJlc3RyaWN0aW9uLnRzeA==) | `69.69% <0.00%> (-21.22%)` | :arrow_down: |
| [web/src/pages/Consumer/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2690/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9MaXN0LnRzeA==) | `73.17% <0.00%> (-19.52%)` | :arrow_down: |
| [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2690/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | `82.00% <0.00%> (-17.00%)` | :arrow_down: |
| [web/src/components/ActionBar/ActionBar.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2690/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL0FjdGlvbkJhci9BY3Rpb25CYXIudHN4) | `69.23% <0.00%> (-15.39%)` | :arrow_down: |
| [web/src/app.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2690/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9hcHAudHN4) | `87.87% <0.00%> (-12.13%)` | :arrow_down: |
| [web/src/components/Plugin/UI/cors.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2690/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9jb3JzLnRzeA==) | `71.11% <0.00%> (-11.12%)` | :arrow_down: |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2690/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `64.48% <0.00%> (-10.93%)` | :arrow_down: |
| ... and [153 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2690/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on a diff in pull request #2690: chore: optimize "allow_origins_by_regex tooltip" description
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on code in PR #2690:
URL: https://github.com/apache/apisix-dashboard/pull/2690#discussion_r1048076344
##########
web/src/components/Plugin/locales/en-US.ts:
##########
@@ -49,7 +49,7 @@ export default {
'component.pluginForm.cors.allow_origins_by_metadata.tooltip':
'Match which origin is allowed to enable CORS by referencing allow_origins set in plugin metadata.',
'component.pluginForm.cors.allow_origins_by_regex.tooltip':
- 'Use regex expressions to match which origin is allowed to enable CORS, for example, [".*.test.com"] can use to match all subdomain of test.com.',
+ 'Use regex expressions to match which origin is allowed to enable CORS. Each form can only be configured with a single, standalone regular expression, such as ".*.test.com" which can match any subdomain of test.com.',
Review Comment:
```suggestion
'Use regex expressions to match which origin is allowed to enable CORS. Each input box can only be configured with a single, standalone regular expression, such as ".*.test.com" which can match any subdomain of test.com.',
```
##########
web/src/components/Plugin/locales/tr-TR.ts:
##########
@@ -49,7 +49,7 @@ export default {
'component.pluginForm.cors.allow_origins_by_metadata.tooltip':
'Eklenti meta verilerindeki allow_origins kümesine başvurarak CORSu etkinleştirmek için hangi Origine izin verildiğini eşleştirin.',
'component.pluginForm.cors.allow_origins_by_regex.tooltip':
- 'CORSu etkinleştirmek için hangi Origine izin verildiğini eşleştirmek için normal ifade ifadeleri kullanın, örneğin, [".*.test.com"], test.comun tüm alt alan adlarını eşleştirmek için kullanabilir.',
+ 'CORSu etkinleştirmek için izin verilen kaynakları eşleştirmek için regex ifadelerini kullanın. Her form sadece tek bir, bağımsız düzenli ifadeyle yapılandırılabilir, örneğin ".*.test.com" gibi, test.com\'un her alt etki alanını eşleştirebilir.',
Review Comment:
ditto
##########
web/src/components/Plugin/locales/zh-CN.ts:
##########
@@ -48,7 +48,7 @@ export default {
'component.pluginForm.cors.allow_origins_by_metadata.tooltip':
'通过引用插件元数据的 allow_origins 配置允许跨域访问的 Origin。',
'component.pluginForm.cors.allow_origins_by_regex.tooltip':
- '使用正则表达式数组来匹配允许跨域访问的 Origin, 如[".*.test.com"] 可以匹配任何test.com的子域名 * 。',
+ '使用正则表达式来匹配允许跨域访问的 Origin, 每一个表单仅可以配置一个独立的正则表达式，如".*.test.com" 可以匹配任何test.com的子域名 * 。',
Review Comment:
```suggestion
'使用正则表达式来匹配允许跨域访问的 Origin, 每一个输入框仅可以配置一个独立的正则表达式，如".*.test.com" 可以匹配任何test.com的子域名 * 。',
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] mscb402 commented on a diff in pull request #2690: chore: optimize "allow_origins_by_regex tooltip" description
Posted by GitBox <gi...@apache.org>.
mscb402 commented on code in PR #2690:
URL: https://github.com/apache/apisix-dashboard/pull/2690#discussion_r1048077356
##########
web/src/components/Plugin/locales/tr-TR.ts:
##########
@@ -49,7 +49,7 @@ export default {
'component.pluginForm.cors.allow_origins_by_metadata.tooltip':
'Eklenti meta verilerindeki allow_origins kümesine başvurarak CORSu etkinleştirmek için hangi Origine izin verildiğini eşleştirin.',
'component.pluginForm.cors.allow_origins_by_regex.tooltip':
- 'CORSu etkinleştirmek için hangi Origine izin verildiğini eşleştirmek için normal ifade ifadeleri kullanın, örneğin, [".*.test.com"], test.comun tüm alt alan adlarını eşleştirmek için kullanabilir.',
+ 'CORSu etkinleştirmek için izin verilen kaynakları eşleştirmek için regex ifadelerini kullanın. Her form sadece tek bir, bağımsız düzenli ifadeyle yapılandırılabilir, örneğin ".*.test.com" gibi, test.com\'un her alt etki alanını eşleştirebilir.',
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 merged pull request #2690: chore: optimize "allow_origins_by_regex tooltip" description
Posted by GitBox <gi...@apache.org>.
bzp2010 merged PR #2690:
URL: https://github.com/apache/apisix-dashboard/pull/2690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] mscb402 commented on pull request #2690: chroe: optimize "allow_origins_by_regex tooltip" description
Posted by GitBox <gi...@apache.org>.
mscb402 commented on PR #2690:
URL: https://github.com/apache/apisix-dashboard/pull/2690#issuecomment-1348030586
@tokers @bzp2010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org