You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/20 12:33:59 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7131: poll: add poll_notify() api and call it in all drivers.

xiaoxiang781216 commented on PR #7131:
URL: https://github.com/apache/incubator-nuttx/pull/7131#issuecomment-1252289466

   > Do we have good test coverage for this change? I see that many places did not check `fd->sem` count before posting, but now in common function it is always checked. The impact seems to be quite high from the bird eye view.
   
   The check is intent: it is unnecessary to post semaphore more than once because there is one and only one thread is waiting for it:
   https://github.com/apache/incubator-nuttx/blob/master/fs/vfs/fs_poll.c#L423
   you can see sem is a local variable defined at line 365.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org