You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2015/12/05 01:35:08 UTC
Review Request 41000: Shortened allocation_interval in
ReservationTests to avoid flakiness.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41000/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Michael Park.
Bugs: MESOS-4067
https://issues.apache.org/jira/browse/MESOS-4067
Repository: mesos
Description
-------
Shortened allocation_interval in ReservationTests to avoid flakiness.
Diffs
-----
src/tests/reservation_tests.cpp 3fdf5e121840fe99057e917cca48f1425eff6624
Diff: https://reviews.apache.org/r/41000/diff/
Testing
-------
`GTEST_FILTER="ReservationTest.*" bin/mesos-tests.sh --gtest_repeat=1000 --gtest_break_on_failure`
While only ACLMultipleOperations is currently flaky, in this patch I shorten the `allocation_interval` for all tests in this file to avoid flakiness in the future as the tests are modified, instead promoting hard failures that will be easy to identify.
Thanks,
Greg Mann
Re: Review Request 41000: Shortened allocation_interval in
ReservationTests to avoid flakiness.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41000/#review109462
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Dec. 5, 2015, 12:35 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41000/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2015, 12:35 a.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-4067
> https://issues.apache.org/jira/browse/MESOS-4067
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Shortened allocation_interval in ReservationTests to avoid flakiness.
>
>
> Diffs
> -----
>
> src/tests/reservation_tests.cpp 3fdf5e121840fe99057e917cca48f1425eff6624
>
> Diff: https://reviews.apache.org/r/41000/diff/
>
>
> Testing
> -------
>
> `GTEST_FILTER="ReservationTest.*" bin/mesos-tests.sh --gtest_repeat=1000 --gtest_break_on_failure`
>
> While only ACLMultipleOperations is currently flaky, in this patch I shorten the `allocation_interval` for all tests in this file to avoid flakiness in the future as the tests are modified, instead promoting hard failures that will be easy to identify.
>
>
> Thanks,
>
> Greg Mann
>
>