[GitHub] [jmeter] vlsi commented on pull request #5715: Update darklaf to version 3.0.2

["vlsi (via GitHub)" <gi...@apache.org>]

vlsi commented on PR #5715:
URL: https://github.com/apache/jmeter/pull/5715#issuecomment-1594652698

   @weisJ , it looks like Java lacks ability to attach a resource bundle: https://bugs.openjdk.org/browse/JDK-4834404
   
   They say
   
   > addResourceBundle was intended for internal use only, therefor it doesn't
   > correctly resolve non-system resource bundles
   
   So it looks like the ways out could be:
   
   a) manually load the resource bundles and add all values from them to UIDefaults
   b) move `darklaf.jar` (or a smaller jar with resources) to a system classpath
   
   Technically speaking, I think we should stop using `DynamicClassLoader` as it makes the code hard to reason, and it makes the loading tricky.
   I believe, the only reason for having `DynamicClassLoader` is:
   
   1) ability to load plugins specified in the UI (extra testplan classpath field)
   2) ability to use a small launcher.jar without supplying full classpath on the command line
   
   We can probably fix it, however, it would take time, so I incline to an approach that would load bundles and pass the values to `UIDefault.put(..)`.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org