You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/11/17 18:28:33 UTC
[jira] [Commented] (TAJO-1188) Fix testcase
testTimestampConstructor in TestTimestampDatum
[ https://issues.apache.org/jira/browse/TAJO-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214874#comment-14214874 ]
ASF GitHub Bot commented on TAJO-1188:
--------------------------------------
GitHub user charsyam opened a pull request:
https://github.com/apache/tajo/pull/249
TAJO-1188: Fix testcase testTimestampConstructor in TestTimestampDatum
This is also timezone bug.
but, before adding timezone info into tajo.
I think it is better to fix testcase for this case.
testTimestampConstructor in TestTimestampDatum will break the test because of timezone.
it compares UTC date and jvm timezone date.
so it needs to set timezone as UTC for Calendar.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/charsyam/tajo feature/fix-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/249.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #249
----
commit bbf203217ca966502a15cd6b72326b3b8a82624c
Author: clark.kang <cl...@kakao.com>
Date: 2014-11-17T17:23:20Z
fix testcases for timezone
----
> Fix testcase testTimestampConstructor in TestTimestampDatum
> -----------------------------------------------------------
>
> Key: TAJO-1188
> URL: https://issues.apache.org/jira/browse/TAJO-1188
> Project: Tajo
> Issue Type: Bug
> Reporter: DaeMyung Kang
> Assignee: DaeMyung Kang
> Priority: Minor
>
> This is also timezone bug.
> but, before adding timezone info into tajo.
> I think it is better to fix testcase for this case.
> testTimestampConstructor in TestTimestampDatum will break the test because of timezone.
> it compares UTC date and jvm timezone date.
> so it needs to set timezone as UTC for Calendar.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)