You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by nickwallen <gi...@git.apache.org> on 2016/09/07 15:30:24 UTC
[GitHub] incubator-metron pull request #245: METRON-408 Intermittent Failures of Prof...
GitHub user nickwallen opened a pull request:
https://github.com/apache/incubator-metron/pull/245
METRON-408 Intermittent Failures of Profile Integration Tests
[METRON-408](https://issues.apache.org/jira/browse/METRON-408)
The profiler configuration was not being updated from Zookeeper correctly in all cases. After some period of time the configurations would be updated and the tests would work. But if this period of time was greater than 90 seconds, the amount of time the profile integration tests wait, then the tests would fail.
In all cases, messages were being sent through Storm prior to the bolt actually receiving the profiler configuration, which would cause the `ProfileSplitterBolt` to throw an exception indicating that the configuration could not be found. This message `Fatal: Unable to find valid profiler definition` was a symptom of the problem and occurred much more frequently than the tests actually failed.
Since this issue was intermittent, I cannot be sure it is completely gone, but I have been unable to replicate the problem after these changes. I also am unable to replicate the `Fatal: Unable to find valid profiler definition` error after this fix.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/incubator-metron METRON-408
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/245.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #245
----
commit d496b4b3a169f6224d5ab07927299277e3cc85b2
Author: Nick Allen <ni...@nickallen.org>
Date: 2016-09-07T14:40:33Z
METRON-408 Intermittent Failures of Profile Integration Tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #245: METRON-408 Intermittent Failures of Profile Int...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/incubator-metron/pull/245
Looks good, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #245: METRON-408 Intermittent Failures of Prof...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-metron/pull/245
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #245: METRON-408 Intermittent Failures of Prof...
Posted by nickwallen <gi...@git.apache.org>.
GitHub user nickwallen reopened a pull request:
https://github.com/apache/incubator-metron/pull/245
METRON-408 Intermittent Failures of Profile Integration Tests
[METRON-408](https://issues.apache.org/jira/browse/METRON-408)
The profiler configuration was not being updated from Zookeeper correctly in all cases. After some period of time the configurations would be updated and the tests would work. But if this period of time was greater than 90 seconds, the amount of time the profile integration tests wait, then the tests would fail.
In all cases, messages were being sent through Storm prior to the bolt actually receiving the profiler configuration, which would cause the `ProfileSplitterBolt` to throw an exception indicating that the configuration could not be found. This message `Fatal: Unable to find valid profiler definition` was a symptom of the problem and occurred much more frequently than the tests actually failed.
Since this issue was intermittent, I cannot be sure it is completely gone, but I have been unable to replicate the problem after these changes. I also am unable to replicate the `Fatal: Unable to find valid profiler definition` error after this fix.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/incubator-metron METRON-408
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/245.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #245
----
commit d496b4b3a169f6224d5ab07927299277e3cc85b2
Author: Nick Allen <ni...@nickallen.org>
Date: 2016-09-07T14:40:33Z
METRON-408 Intermittent Failures of Profile Integration Tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #245: METRON-408 Intermittent Failures of Prof...
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen closed the pull request at:
https://github.com/apache/incubator-metron/pull/245
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---