You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tika.apache.org by dm...@apache.org on 2020/11/30 21:51:01 UTC

[tika-docker] 22/28: changed entrypoint to exec format

This is an automated email from the ASF dual-hosted git repository.

dmeikle pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tika-docker.git

commit f5e6a2ced02f93e83aa97dde4a41458eeaca35e4
Author: Schmitt Christian <c....@briefdomain.de>
AuthorDate: Tue Sep 1 18:22:56 2020 +0200

    changed entrypoint to exec format
    
    this also enables people to specify additional params, which is not possible in the current form:
    https://docs.docker.com/engine/reference/builder/#entrypoint
    
    > The shell form prevents any CMD or run command line arguments from being used, but has the disadvantage that your ENTRYPOINT will be started as a subcommand of /bin/sh -c, which does not pass signals. This means that the executable will not be the container’s PID 1 - and will not receive Unix signals - so your executable will not receive a SIGTERM from docker stop <container>.
---
 full/Dockerfile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/full/Dockerfile b/full/Dockerfile
index 0d93c72..e88aade 100644
--- a/full/Dockerfile
+++ b/full/Dockerfile
@@ -49,7 +49,7 @@ ENV TIKA_VERSION=$TIKA_VERSION
 COPY --from=fetch_tika /tika-server-${TIKA_VERSION}.jar /tika-server-${TIKA_VERSION}.jar
 
 EXPOSE 9998
-ENTRYPOINT java -jar /tika-server-${TIKA_VERSION}.jar -h 0.0.0.0
+ENTRYPOINT ["java", "-jar", "/tika-server-${TIKA_VERSION}.jar", "-h", "0.0.0.0"]
 
 LABEL maintainer="Apache Tika Developers dev@tika.apache.org"