You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/09/15 15:25:31 UTC

[GitHub] benmccrea commented on a change in pull request #1400: [DO NOT MERGE] - Fix BQ27Z561 and LP5523 I2C repeated-stop operations

benmccrea commented on a change in pull request #1400: [DO NOT MERGE] - Fix BQ27Z561 and LP5523 I2C repeated-stop operations
URL: https://github.com/apache/mynewt-core/pull/1400#discussion_r217887585
 
 

 ##########
 File path: hw/drivers/bq27z561/src/bq27z561.c
 ##########
 @@ -41,6 +41,9 @@
 #define BQ27Z561_LOG(lvl_, ...)
 #endif
 
+#define BQ27Z561_I2C_TIMEOUT_TICKS \
+    ((1000 / OS_TICKS_PER_SEC) / MYNEWT_VAL(BQ27Z561_I2C_TIMEOUT_MS))
 
 Review comment:
   Good catch. It was meant to be:
    > MYNEWT_VAL(BQ27Z561_I2C_TIMEOUT_MS) /  (1000 / OS_TICKS_PER_SEC)
   But I like your way better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services