You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/15 23:54:17 UTC

[GitHub] [arrow-rs] viirya commented on a diff in pull request #3345: Fix unary_dyn for decimal scalar arithmetic computation

viirya commented on code in PR #3345:
URL: https://github.com/apache/arrow-rs/pull/3345#discussion_r1050245680


##########
arrow/src/compute/kernels/arity.rs:
##########
@@ -135,14 +138,15 @@ where
     downcast_dictionary_array! {
         array => unary_dict::<_, F, T>(array, op),
         t => {
-            if t == &T::DATA_TYPE {
+            if t == &T::DATA_TYPE || (t.is_decimal() && T::DATA_TYPE.is_decimal())  {

Review Comment:
   Learnt about discriminant now. 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org