回复： [DISCUSS] About modify workflow instance function

[yongqing <59...@qq.com>]

+1




------------------ 原始邮件 ------------------
发件人:                                                                                                                        "dev"                                                                                    <wenhemin@apache.org&gt;;
发送时间:&nbsp;2020年12月2日(星期三) 上午10:27
收件人:&nbsp;"dev"<dev@dolphinscheduler.apache.org&gt;;

主题:&nbsp;Re: [DISCUSS] About modify workflow instance function



This function does logically conflict with the online function. The purpose
of the online function is to prevent workflow changes, and then another
workflow change is opened.
It is better to be more rigorous in workflow change operations. It is a
low-frequency operation. Through offline, modification, and online again,
operators can also know what they are doing.

---

这个功能在逻辑上确实和上线功能是冲突的，上线功能的目的也是防止工作流变更，
然后又开了另外一个工作流变更的口子

工作流变更操作严谨一些更好，本来就是低频操作，通过下线、修改、再上线也让
操作人知道自己在做什么


--------------------
DolphinScheduler(Incubator) Commtter
Hemin Wen&nbsp; 温合民
wenhemin@apache.org
--------------------


wu shaoj <shaojwu@gmail.com&gt; 于2020年12月2日周三 上午9:56写道：

&gt; I can’t agree with @ Hemin Wen more.
&gt;
&gt; 我也认为不应该提供直接修改工作流实例的功能，不能说因为简单就要添加这样的功能。如果觉得offline、online麻烦，是不是意味着offline、online的功能不合理？
&gt; 另外测试工作流实例，然后去更新工作流？这是什么鬼畜逻辑？绝对应该先定义好工作流，再去测试
&gt;
&gt;
&gt; From: lgcareer2019@outlook.com <lgcareer2019@outlook.com&gt;
&gt; Date: Tuesday, December 1, 2020 at 10:42
&gt; To: dev <dev@dolphinscheduler.apache.org&gt;
&gt; Subject: Re: [DISCUSS] About modify workflow instance function
&gt; I think it's neccesary to keep this function.
&gt;
&gt; 1.If we need update the proress definition,If upate the process definiton
&gt; direcly,we need change it's state from online to offline,and when we
&gt; modified,need change it's state from offline to online.
&gt; So&nbsp; I think it's easy-to-use to keep the function, when update the process
&gt; instance support the choise whether decide to update the process definition.
&gt;
&gt; 2.It's have another benefit,we can test the process instance first,if it
&gt; runs successful,then we can decide to update the process definition
&gt; directly.
&gt;
&gt; Of course,we can enhance this function with permission controler,Such as
&gt; only someone who have permission can update the process definiton by update
&gt; the process instance.
&gt;
&gt;
&gt;
&gt; Best Regards
&gt;
&gt; DolphinScheduler(Incubator) PPMC
&gt; Gang Li 李岗
&gt;
&gt; lgcareer@apache.org
&gt;
&gt; From: Hemin Wen
&gt; Date: 2020-11-30 10:09
&gt; To: dev
&gt; Subject: [DISCUSS] About modify workflow instance function
&gt; Hi, all!
&gt;
&gt; Currently, DS supports editing workflow instance while updating workflow
&gt; definition,
&gt; You can also choose not to update the workflow definition, there is a check
&gt; box here.
&gt;
&gt; I guess the reason of this design, Add the entry in the workflow instance,
&gt; Workflow can be updated without offline workflow definition.
&gt;
&gt; I did not think of a scenario where only the workflow instance is updated.
&gt; Modifying only the workflow instance without updating the definition will
&gt; also lead to inconsistent data.
&gt;
&gt; So, Is it possible to remove the check box for updating the workflow
&gt; definition here?
&gt;
&gt; --------------------
&gt; DolphinScheduler(Incubator) Commtter
&gt; Hemin Wen&nbsp; 温合民
&gt; wenhemin@apache.org
&gt; --------------------
&gt;