You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/07/10 17:18:49 UTC
[GitHub] [accumulo] friedlou opened a new issue #1655: Unable to set bulk import tries to only once.
friedlou opened a new issue #1655:
URL: https://github.com/apache/accumulo/issues/1655
There are two properties that control the number of times a bulk import is attempted: master.bulk.retries and tserver.bulk.retry.max.
master.bulk.retries is used by LoadFiles.java to limit the number of retries. The code treats this value as the number of total attempts, not the number of retries. So if it is set to 1, only one attempt is made to load the files before reporting failure. (The code forces it to 1 even if the property is set to 0.)
tserver.bulk.retry.max is used by BulkImporter.java to limit the number of retires. However, it treats this value as the number retries. The number of attempts would be 1 + the value in the property. So if it is set to 0, only one attempt should be made to load the files. However, this is not what happens. Even when the property is set to 0, two attempts are made to load the file before reporting failure. This needs to be fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] tynyttie commented on issue #1655: Unable to set bulk import tries to only once.
Posted by GitBox <gi...@apache.org>.
tynyttie commented on issue #1655:
URL: https://github.com/apache/accumulo/issues/1655#issuecomment-683801293
Sure, I would love to. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] friedlou commented on issue #1655: Unable to set bulk import tries to only once.
Posted by GitBox <gi...@apache.org>.
friedlou commented on issue #1655:
URL: https://github.com/apache/accumulo/issues/1655#issuecomment-675473232
Yes, you are understanding it correctly.
On Tue, Jul 28, 2020 at 11:19 PM Christopher Tubbs <no...@github.com>
wrote:
> I commented on #1656 <https://github.com/apache/accumulo/pull/1656>
> before seeing the this issue. Sorry for that, @friedlou
> <https://github.com/friedlou> . In future, it would be good to provide
> some context in the commit that makes a change, describing the motivation
> for the change. In this case, it seems to be attempting to fix a bug where
> tserver.bulk.retry.max retries even when the number of retries is set to 0.
> Am I understanding the issue correctly?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/accumulo/issues/1655#issuecomment-665407319>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AIYRTI45ACFQBCKLFAXQLRTR56INHANCNFSM4OWY5ZOA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on issue #1655: Unable to set bulk import tries to only once.
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #1655:
URL: https://github.com/apache/accumulo/issues/1655#issuecomment-665407319
I commented on #1656 before seeing the this issue. Sorry for that, @friedlou . In future, it would be good to provide some context in the commit that makes a change, describing the motivation for the change. In this case, it seems to be attempting to fix a bug where `tserver.bulk.retry.max` retries even when the number of retries is set to `0`. Am I understanding the issue correctly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] tynyttie commented on issue #1655: Unable to set bulk import tries to only once.
Posted by GitBox <gi...@apache.org>.
tynyttie commented on issue #1655:
URL: https://github.com/apache/accumulo/issues/1655#issuecomment-683495699
Hi. I will look into this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on issue #1655: Unable to set bulk import tries to only once.
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #1655:
URL: https://github.com/apache/accumulo/issues/1655#issuecomment-683517456
@tynyttie , there's already an open PR for this at #1656 ; if you're interested in helping with this issue, you could review that code change and provide feedback there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org