You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/10/17 13:19:41 UTC
[GitHub] [incubator-linkis] jacktao007 commented on a diff in pull request #3664: [linkis-cs-common ]module errorcode optimization and documentation
jacktao007 commented on code in PR #3664:
URL: https://github.com/apache/incubator-linkis/pull/3664#discussion_r997050396
##########
linkis-public-enhancements/linkis-context-service/linkis-cs-server/src/main/java/org/apache/linkis/cs/highavailable/proxy/MethodInterceptorImpl.java:
##########
@@ -37,6 +36,8 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import static org.apache.linkis.cs.common.errorcode.CsCommonErrorCodeSummary.*;
+
/**
* 基于CGLib库实现的动态代理拦截器，拦截被代理方法的参数，在被代理方法之前和之后进行增强
* 被代理方法调用前增强场景较多，一般对参数为HAContextID实例、参数名包含contextid的方法参数进行转换
Review Comment:
It can be described in English
##########
linkis-public-enhancements/linkis-context-service/linkis-cs-server/src/main/java/org/apache/linkis/cs/server/service/impl/ContextServiceImpl.java:
##########
@@ -125,7 +127,8 @@ public void setValueByKey(ContextID contextID, ContextKey contextKey, ContextVal
if (keyValue == null) {
// 创建校验scope和tye
Review Comment:
It can be described in English
##########
linkis-public-enhancements/linkis-context-service/linkis-cs-client/src/main/java/org/apache/linkis/cs/client/http/HttpContextClient.java:
##########
@@ -54,6 +54,8 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import static org.apache.linkis.cs.common.errorcode.CsCommonErrorCodeSummary.*;
+
/** Description: HttpContextClient是ContextClient的使用Http方式进行通信的具体实现 一般可以将其做成单例 */
Review Comment:
It can be described in English
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org