You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/12/13 09:33:10 UTC

[GitHub] [hudi] lokeshj1703 commented on pull request #7432: [HUDI-5374] Use KeyGeneratorFactory class for instantiating a KeyGenerator

lokeshj1703 commented on PR #7432:
URL: https://github.com/apache/hudi/pull/7432#issuecomment-1348050037

   #### Classes Affected - Old behavior
   KafkaConnectTransactionServices - Uses type config if available else defaults to SIMPLE
   HoodieDatasetBulkInsertHelper - Uses class config if available 
   SqlKeyGenerator - Uses class config if available 
   
   New behavior  - first class is checked, then type config with default value of SIMPLE.
   
   Azure CI test is failing because TestHoodieDatasetBulkInsertHelper#testNoPropsSet expects an exception since class config is not set and new behavior allows SIMPLE by default in HoodieDatasetBulkInsertHelper.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org