You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/08 06:18:51 UTC

[GitHub] [pulsar] Jason918 commented on a diff in pull request #15478: PIP-117: Change Pulsar standalone defaults

Jason918 commented on code in PR #15478:
URL: https://github.com/apache/pulsar/pull/15478#discussion_r867440862


##########
pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandalone.java:
##########
@@ -246,7 +259,10 @@ public boolean isHelp() {
     @Parameter(names = { "-h", "--help" }, description = "Show this help message")
     private boolean help = false;
 
+    private boolean usingNew211Defaults;
+
     public void start() throws Exception {
+        usingNew211Defaults = !Paths.get(zkDir).toFile().exists();

Review Comment:
   A warning log would be great when both `--metadata-dir` is provided and `zkDir` exists.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org