[GitHub] [incubator-shardingsphere] tuohai666 commented on a change in pull request #2669: fix 'Unsupported data type:boolean' ShardingException

[GitBox <gi...@apache.org>]

tuohai666 commented on a change in pull request #2669: fix 'Unsupported data type:boolean' ShardingException
URL: https://github.com/apache/incubator-shardingsphere/pull/2669#discussion_r300908537
 
 

 ##########
 File path: sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/resultset/ResultSetUtil.java
 ##########
 @@ -85,6 +85,8 @@ private static Object convertNullValue(final Class<?> convertType) {
     private static Object convertNumberValue(final Object value, final Class<?> convertType) {
         Number number = (Number) value;
         switch (convertType.getName()) {
+	        case "boolean":
 
 Review comment:
   I think this change proved wrong last week by your test. What does this pr mean?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services