You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "David Jencks (JIRA)" <ji...@apache.org> on 2008/12/29 08:55:05 UTC
[jira] Created: (AMQ-2045) Unbalanced Valve usage in VMTransport.
Unbalanced Valve usage in VMTransport.
--------------------------------------
Key: AMQ-2045
URL: https://issues.apache.org/activemq/browse/AMQ-2045
Project: ActiveMQ
Issue Type: Bug
Components: Transport
Affects Versions: 5.3.0
Reporter: David Jencks
Assignee: David Jencks
Fix For: 5.3.0
Valve doesn't check that its state is consistent (counters >= 0). There's unbalanced increment/decrement calls in VMTransport.oneway:
enqueueValve.decrement(); //TODO unbalanced??
(line ~99)
If I balance this with a preceding enqueValve.increment() I get a deadlock in a test when the server tries to send a response message so I assume the correct fix is to remove the decrement in this VMTransports valve.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (AMQ-2045) Unbalanced Valve usage in VMTransport.
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks resolved AMQ-2045.
-------------------------------
Resolution: Fixed
Assignee: Hiram Chirino (was: David Jencks)
rev 729835 adds consistency checks to Valve and removes the unbalanced decrement. IMO this should be reviewed by a more knowledgeable developer before closing... Hiram can you take a look or suggest someone who could?
> Unbalanced Valve usage in VMTransport.
> --------------------------------------
>
> Key: AMQ-2045
> URL: https://issues.apache.org/activemq/browse/AMQ-2045
> Project: ActiveMQ
> Issue Type: Bug
> Components: Transport
> Affects Versions: 5.3.0
> Reporter: David Jencks
> Assignee: Hiram Chirino
> Fix For: 5.3.0
>
>
> Valve doesn't check that its state is consistent (counters >= 0). There's unbalanced increment/decrement calls in VMTransport.oneway:
> enqueueValve.decrement(); //TODO unbalanced??
> (line ~99)
> If I balance this with a preceding enqueValve.increment() I get a deadlock in a test when the server tries to send a response message so I assume the correct fix is to remove the decrement in this VMTransports valve.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQ-2045) Unbalanced Valve usage in VMTransport.
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48428#action_48428 ]
Hiram Chirino commented on AMQ-2045:
------------------------------------
Looks good. Perhaps we should change those consistency checks to assert calls so that users can avoid doing them in production since they are being done in synchronized blocks.
> Unbalanced Valve usage in VMTransport.
> --------------------------------------
>
> Key: AMQ-2045
> URL: https://issues.apache.org/activemq/browse/AMQ-2045
> Project: ActiveMQ
> Issue Type: Bug
> Components: Transport
> Affects Versions: 5.3.0
> Reporter: David Jencks
> Assignee: Hiram Chirino
> Fix For: 5.3.0
>
>
> Valve doesn't check that its state is consistent (counters >= 0). There's unbalanced increment/decrement calls in VMTransport.oneway:
> enqueueValve.decrement(); //TODO unbalanced??
> (line ~99)
> If I balance this with a preceding enqueValve.increment() I get a deadlock in a test when the server tries to send a response message so I assume the correct fix is to remove the decrement in this VMTransports valve.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.